opendev/gerrit
Code Issues Proposed changes

Remove unneeded null checks

Browse Source 
These null checks are not needed since the variables were previously
dereferenced and if they were null a NullPointerException would have
occurred then.

Change-Id: Ied6a3b32b2580a0d95f74053a1867130780e208b
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
This commit is contained in:
Edwin Kempin
2013-08-22 15:27:33 +02:00
parent 1d947bf77c
commit ad3e8bd921
4 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeScreen.java
View File

@@ -339,13 +339,11 @@ public class ChangeScreen extends Screen
patchesList.addItem(Util.C.baseDiffItem());
}
for (PatchSet pId : detail.getPatchSets()) {
if (patchesList != null) {
patchesList.addItem(Util.M.patchSetHeader(pId.getPatchSetId()), pId
.getId().toString());
}
patchesList.addItem(Util.M.patchSetHeader(pId.getPatchSetId()), pId
.getId().toString());
}
if (diffBaseId != null && patchesList != null) {
if (diffBaseId != null) {
patchesList.setSelectedIndex(diffBaseId.get());
}