opendev/gerrit
Code Issues Proposed changes

Remove old changeDetail RPC

Browse Source 
Convert the new RPC data into the old data, just enough to keep the
old UI alive against a newer server.  This will allow us to build a
final version of the old UI code and run it for quite some time
against a modern REST API.

Users who refuse to upgrade to ChangeScreen2 can run this frozen old
UI build until it no longer works.

Change-Id: Ieef15c39e97673f6bcdeb03567fc48ddbd289a6e
This commit is contained in:
Shawn Pearce
2013-12-05 21:00:52 -08:00
parent dd5f4ca82a
commit adb91286f8
13 changed files with 493 additions and 529 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-common/src/main/java/com/google/gerrit/common/data/AccountInfo.java
View File

@@ -52,6 +52,10 @@ public class AccountInfo {
return id;
}
public void setFullName(String n) {
fullName = n;
}
/** @return the full name of the account holder; null if not supplied */
public String getFullName() {
return fullName;

7
gerrit-common/src/main/java/com/google/gerrit/common/data/ChangeDetailService.java
View File

@@ -17,7 +17,6 @@ package com.google.gerrit.common.data;
import com.google.gerrit.common.audit.Audit;
import com.google.gerrit.common.auth.SignInRequired;
import com.google.gerrit.reviewdb.client.AccountDiffPreference;
import com.google.gerrit.reviewdb.client.Change;
import com.google.gerrit.reviewdb.client.PatchSet;
import com.google.gwtjsonrpc.common.AsyncCallback;
import com.google.gwtjsonrpc.common.RemoteJsonService;
@@ -26,12 +25,6 @@ import com.google.gwtjsonrpc.common.RpcImpl.Version;
@RpcImpl(version = Version.V2_0)
public interface ChangeDetailService extends RemoteJsonService {
@Audit
void changeDetail(Change.Id id, AsyncCallback<ChangeDetail> callback);
@Audit
void includedInDetail(Change.Id id, AsyncCallback<IncludedInDetail> callback);
@Audit
void patchSetDetail(PatchSet.Id key, AsyncCallback<PatchSetDetail> callback);

6
gerrit-common/src/main/java/com/google/gerrit/common/data/ChangeInfo.java
View File

@@ -35,10 +35,14 @@ public class ChangeInfo {
protected PatchSet.Id patchSetId;
protected boolean latest;
protected ChangeInfo() {
public ChangeInfo() {
}
public ChangeInfo(final Change c, final PatchSet.Id patchId) {
set(c, patchId);
}
public void set(final Change c, final PatchSet.Id patchId) {
id = c.getId();
key = c.getKey();
owner = c.getOwner();