opendev/gerrit
Code Issues Proposed changes

Correct enter key detection in project creation screen

Browse Source 
Detecting enter key press with `getCharCode()` does not work properly in
all browsers, for example Firefox.

Instead, `getNativeEvent().getKeyCode()` should be used.

Change-Id: Ib94c8af93ab67d5a8fd62c9c25b6d5ea83de7017
This commit is contained in:
Christian Aistleitner
2013-03-03 18:36:53 +01:00
committed by David Pursehouse
parent 1c830c11e7
commit adcfdfd263
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/CreateProjectScreen.java
View File

@@ -132,7 +132,7 @@ public class CreateProjectScreen extends Screen {
project.addKeyPressHandler(new KeyPressHandler() { project.addKeyPressHandler(new KeyPressHandler() {
@Override @Override
public void onKeyPress(KeyPressEvent event) { public void onKeyPress(KeyPressEvent event) {
if (event.getCharCode() == KeyCodes.KEY_ENTER) { if (event.getNativeEvent().getKeyCode() == KeyCodes.KEY_ENTER) {
doCreateProject(); doCreateProject();
} }
} }