opendev/gerrit
Code Issues Proposed changes

Merge "Expose change, patchRange to plugin endpoints in gr-file-list"

Browse Source
This commit is contained in:
Tao Zhou
2020-06-19 10:20:37 +00:00
committed by Gerrit Code Review
parent 53cfbc7697 f4a762340f
commit adcff18a70
1 changed files with 20 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
polygerrit-ui/app/elements/change/gr-file-list/gr-file-list_html.js
View File

@@ -329,6 +329,12 @@ export const htmlTemplate = html`
as="headerEndpoint"
>
<gr-endpoint-decorator name$="[[headerEndpoint]]" role="columnheader">
<gr-endpoint-param
name="change"
value="[[change]]"
></gr-endpoint-param>
<gr-endpoint-param name="patchRange" value="[[patchRange]]">
</gr-endpoint-param>
</gr-endpoint-decorator>
</template>
</template>
@@ -381,6 +387,8 @@ export const htmlTemplate = html`
as="contentEndpoint"
>
<gr-endpoint-decorator name="[[contentEndpoint]]" role="gridcell">
<gr-endpoint-param name="change" value="[[change]]">
</gr-endpoint-param>
<gr-endpoint-param name="changeNum" value="[[changeNum]]">
</gr-endpoint-param>
<gr-endpoint-param name="patchRange" value="[[patchRange]]">
@@ -439,7 +447,7 @@ export const htmlTemplate = html`
<div class="comments desktop">
<span class="drafts"
><!-- This comments ensure that span is empty when the function
returns empty string.
returns empty string.
-->[[_computeDraftsString(changeComments, patchRange,
file.__path)]]<!-- This comments ensure that span is empty when
the function returns empty string.
@@ -458,7 +466,7 @@ export const htmlTemplate = html`
Without this span, screen readers don't navigate correctly inside
table, because empty div doesn't rendered. For example, VoiceOver
jumps back to the whole table.
We can use &nbsp instead, but it sounds worse.
We can use &nbsp instead, but it sounds worse.
-->
No comments
</span>
@@ -553,6 +561,8 @@ export const htmlTemplate = html`
>
<div class$="[[_computeClass('', file.__path)]]" role="gridcell">
<gr-endpoint-decorator name="[[contentEndpoint]]">
<gr-endpoint-param name="change" value="[[change]]">
</gr-endpoint-param>
<gr-endpoint-param name="changeNum" value="[[changeNum]]">
</gr-endpoint-param>
<gr-endpoint-param name="patchRange" value="[[patchRange]]">
@@ -575,7 +585,7 @@ export const htmlTemplate = html`
>
<!-- Do not use input type="checkbox" with hidden input and
visible label here. Screen readers don't read/interract
correctly with such input.
correctly with such input.
-->
<span
class="reviewedSwitch"
@@ -611,7 +621,7 @@ export const htmlTemplate = html`
<div class="show-hide" role="gridcell">
<!-- Do not use input type="checkbox" with hidden input and
visible label here. Screen readers don't read/interract
correctly with such input.
correctly with such input.
-->
<span
class="show-hide"
@@ -683,6 +693,12 @@ export const htmlTemplate = html`
as="summaryEndpoint"
>
<gr-endpoint-decorator name="[[summaryEndpoint]]">
<gr-endpoint-param
name="change"
value="[[change]]"
></gr-endpoint-param>
<gr-endpoint-param name="patchRange" value="[[patchRange]]">
</gr-endpoint-param>
</gr-endpoint-decorator>
</template>
</template>