diff --git a/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.html b/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.html index eeae3b12b3..b90bed8eac 100644 --- a/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.html +++ b/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.html @@ -251,7 +251,9 @@ limitations under the License. change="{{_change}}" commit-info="[[_commitInfo]]" server-config="[[serverConfig]]" - mutable="[[_loggedIn]]"> + mutable="[[_loggedIn]]" + on-show-reply-dialog="_handleShowReplyDialog"> + -
-
-
- - × -
-
Add reviewer + on-tap="_handleAddTap">Add reviewer
diff --git a/polygerrit-ui/app/elements/change/gr-reviewer-list/gr-reviewer-list.js b/polygerrit-ui/app/elements/change/gr-reviewer-list/gr-reviewer-list.js index 2710e53823..7037fc2b08 100644 --- a/polygerrit-ui/app/elements/change/gr-reviewer-list/gr-reviewer-list.js +++ b/polygerrit-ui/app/elements/change/gr-reviewer-list/gr-reviewer-list.js @@ -17,6 +17,12 @@ Polymer({ is: 'gr-reviewer-list', + /** + * Fired when the "Add reviewer..." button is tapped. + * + * @event show-reply-dialog + */ + properties: { change: Object, disabled: { @@ -104,52 +110,7 @@ _handleAddTap: function(e) { e.preventDefault(); - this._showInput = true; - this.$.accountEntry.focus(); - }, - - _handleCancelTap: function(e) { - e.preventDefault(); - this.$.accountEntry.clear(); - this._cancel(); - }, - - _cancel: function() { - this._showInput = false; - this.$.accountEntry.clear(); - this.$.addReviewer.focus(); - }, - - _sendAddRequest: function(e, detail) { - var reviewer = detail.value; - var reviewerID; - if (reviewer.account) { - reviewerID = reviewer.account._account_id; - } else if (reviewer.group) { - reviewerID = reviewer.group.id; - } - - this.disabled = true; - this._xhrPromise = this._addReviewer(reviewerID).then(function(response) { - this.change.reviewers.CC = this.change.reviewers.CC || []; - this.disabled = false; - if (!response.ok) { return response; } - - return this.$.restAPI.getResponseObject(response).then(function(obj) { - obj.reviewers.forEach(function(r) { - this.push('change.removable_reviewers', r); - this.push('change.reviewers.CC', r); - }, this); - this.$.accountEntry.focus(); - }.bind(this)); - }.bind(this)).catch(function(err) { - this.disabled = false; - throw err; - }.bind(this)); - }, - - _addReviewer: function(id) { - return this.$.restAPI.addChangeReviewer(this.change._number, id); + this.fire('show-reply-dialog'); }, _removeReviewer: function(id) { diff --git a/polygerrit-ui/app/elements/change/gr-reviewer-list/gr-reviewer-list_test.html b/polygerrit-ui/app/elements/change/gr-reviewer-list/gr-reviewer-list_test.html index c21158e95f..e6f7a2042a 100644 --- a/polygerrit-ui/app/elements/change/gr-reviewer-list/gr-reviewer-list_test.html +++ b/polygerrit-ui/app/elements/change/gr-reviewer-list/gr-reviewer-list_test.html @@ -34,57 +34,10 @@ limitations under the License.