opendev/gerrit
Code Issues Proposed changes

Remove deprecated gerrit_addHistoryHook(f) JavaScript function

Browse Source 
Instead of this function Gerrit.on('history', f) should be used.

gerrit_addHistoryHook(f) is deprecated since Gerrit 2.9. It's time to
remove it.

Change-Id: I87b23b2d7e404c4a43974d9fff202d11965aad6c
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
This commit is contained in:
Edwin Kempin 2015-07-21 16:02:44 +02:00
parent 68532caf30
commit ae42464225
2 changed files with 0 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Documentation/config-themes.txt
View File

@ -133,9 +133,6 @@ page. Because GWT loads the module asynchronously any `<script>`
block in the header or footer will execute before Gerrit has defined block in the header or footer will execute before Gerrit has defined
the function and is ready to register the hook callback. the function and is ready to register the hook callback.
The function `gerrit_addHistoryHook` is deprecated and may be
removed in a future release.
GERRIT GERRIT
------ ------
Part of link:index.html[Gerrit Code Review] Part of link:index.html[Gerrit Code Review]

9
gerrit-gwtui/src/main/java/com/google/gerrit/client/api/ApiGlue.java
View File

@ -30,7 +30,6 @@ public class ApiGlue {
ActionContext.init(); ActionContext.init();
HtmlTemplate.init(); HtmlTemplate.init();
Plugin.init(); Plugin.init();
addHistoryHook();
} }
private static native void init0() /*-{ private static native void init0() /*-{
@ -203,14 +202,6 @@ public class ApiGlue {
}; };
}-*/; }-*/;
/** Install deprecated {@code gerrit_addHistoryHook()} function. */
private static native void addHistoryHook() /*-{
$wnd.gerrit_addHistoryHook = function(h) {
var p = @com.google.gwt.user.client.Window.Location::getPath()();
$wnd.Gerrit.on('history', function(t) { h(p + "#" + t) })
};
}-*/;
private static void install(JavaScriptObject cb, Plugin p) throws Exception { private static void install(JavaScriptObject cb, Plugin p) throws Exception {
try { try {
pluginName = p.name(); pluginName = p.name();