opendev/gerrit
Code Issues Proposed changes

ProjectApi: Throw ResourceNotFoundException from get/branch

Browse Source 
This can happen when the project is not found, which is a legitimate
state before a project is created. Allow callers to recover by
catching ResourceNotFoundException.

Change-Id: I9ea2638ea996c6adee2a77b841bfc9c5c5afd45a
This commit is contained in:
Dave Borowitz
2015-03-13 10:07:22 -07:00
parent f9dc8bf3f4
commit ae4772a4eb
2 changed files with 18 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
gerrit-extension-api/src/main/java/com/google/gerrit/extensions/api/projects/ProjectApi.java
View File

@@ -21,7 +21,7 @@ import com.google.gerrit.extensions.restapi.RestApiException;
public interface ProjectApi {
ProjectApi create() throws RestApiException;
ProjectApi create(ProjectInput in) throws RestApiException;
ProjectInfo get();
ProjectInfo get() throws RestApiException;
/**
* Look up a branch by refname.
@@ -33,9 +33,10 @@ public interface ProjectApi {
* to store references to {@code BranchApi} instances.
*
* @param ref branch name, with or without "refs/heads/" prefix.
* @throws RestApiException if a problem occurred reading the project.
* @return API for accessing the branch.
*/
BranchApi branch(String ref);
BranchApi branch(String ref) throws RestApiException;
/**
* A default implementation which allows source compatibility
@@ -53,12 +54,12 @@ public interface ProjectApi {
}
@Override
public ProjectInfo get() {
public ProjectInfo get() throws RestApiException {
throw new NotImplementedException();
}
@Override
public BranchApi branch(String ref) {
public BranchApi branch(String ref) throws RestApiException {
throw new NotImplementedException();
}
}