opendev/gerrit
Code Issues Proposed changes

Bazel: Fix more buildifier warnings

Browse Source 
This fixes buildifier warnings that were not fixed in automatic
mode:

  $ find . \( -name BUILD -o -name "*.bzl" \) -print \
      | xargs buildifier --lint=warn

* Remove unused variables
* Pattern `src/test/java/com/google/gerrit/server/project/Util.java`
  has no wildcard ('*')
* All calls to rules or macros should pass arguments by keyword
  (arg_name=value) syntax
* ctx.new_file is deprecated, used ctx.actions.declare_file instead

Change-Id: I1f8a04e8d576ab637ba8a46118720218ec486fff
This commit is contained in:
David Ostrovsky
2018-11-25 05:28:29 +01:00
committed by David Pursehouse
parent 88d0885a57
commit aeaa73e68c
5 changed files with 5 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-gwtui/BUILD
View File

@@ -9,7 +9,7 @@ load("//tools/bzl:license.bzl", "license_test")
gwt_genrule()
gwt_genrule("_r")
gwt_genrule(suffix = "_r")
gen_ui_module(name = "ui_module")