opendev/gerrit
Code Issues Proposed changes

s/broken/flaky/

Browse Source 
Commits introducing broken tests should be fixed or reverted. Flaky
tests, which pass sometimes, are still less than optimal, but are less
likely to be reverted once checked in.

Change-Id: I04d530f35b37cae1faae8bc4a24ea4dc40ee7145
This commit is contained in:
Dave Borowitz 2015-06-22 09:48:33 -07:00
parent c212321f20
commit afd7d3992d
3 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Documentation/dev-buck.txt
View File

@ -297,16 +297,16 @@ To build release and api targets, a combined build target is provided:
[[tests]]
== Running Unit Tests
To run all tests including acceptance tests (but not broken tests):
To run all tests including acceptance tests (but not flaky tests):
----
buck test --exclude broken
buck test --exclude flaky
----
To exclude broken and slow tests:
To exclude flaky and slow tests:
----
buck test --exclude broken slow
buck test --exclude flaky slow
----
To run only a specific group of acceptance tests:
@ -318,9 +318,9 @@ To run only a specific group of acceptance tests:
The following groups of tests are currently supported:
* acceptance
* broken
* api
* edit
* flaky
* git
* pgm
* rest

8
gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/server/project/BUCK
View File

@ -1,13 +1,13 @@
include_defs('//gerrit-acceptance-tests/tests.defs')
BROKEN_TEST_CASES=['ProjectWatchIT.java']
FLAKY_TEST_CASES=['ProjectWatchIT.java']
acceptance_tests(
srcs = glob(['*IT.java'], excludes=BROKEN_TEST_CASES),
srcs = glob(['*IT.java'], excludes=FLAKY_TEST_CASES),
labels = ['server'],
)
acceptance_tests(
srcs = BROKEN_TEST_CASES,
labels = ['server', 'broken'],
srcs = FLAKY_TEST_CASES,
labels = ['server', 'flaky'],
)

2
gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/server/project/ProjectWatchIT.java
View File

@ -40,7 +40,7 @@ public class ProjectWatchIT extends AbstractDaemonTest {
/**
* Tests message project watches on new patch sets
* <p>
* As of 2015-06-21 this test is marked broken for triggering race
* As of 2015-06-21 this test is marked flaky for triggering race
* conditions between indexing and project watches filters as
* of 2015-06-21.
* <p>