opendev/gerrit
Code Issues Proposed changes

Use a glass pane behind our dialogs, make most modal

Browse Source 
We now enable the glass pane behind our dialogs and mark it
with a 0.75 opacity so the page disappears while the error
is being presented.

Most dialogs are modal now and will only dismiss through
their own private close buttons.  This forces the user to
interact with the dialog rather than accidentally sending
it away by clicking elsewhere in the window.

Our error dialog no longer relies upon the DialogBox type
from GWT, but instead draws all of its UI itself.  This is
to avoid the dialog from looking ugly when it cannot load
the remaining resources for the borders.

Change-Id: Ieef4370368a28e31810e270c98f7877adc24061a
Signed-off-by: Shawn O. Pearce <sop@google.com>
This commit is contained in:
Shawn O. Pearce
2009-12-30 16:45:11 -08:00
parent e3e283d4ea
commit afdba93915
10 changed files with 84 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
gerrit-gwtui/src/main/java/com/google/gerrit/client/ErrorDialog.java
View File

@@ -17,27 +17,35 @@ package com.google.gerrit.client;
import com.google.gerrit.client.rpc.RpcConstants;
import com.google.gwt.event.dom.client.ClickEvent;
import com.google.gwt.event.dom.client.ClickHandler;
import com.google.gwt.user.client.Window;
import com.google.gwt.user.client.rpc.StatusCodeException;
import com.google.gwt.user.client.ui.Button;
import com.google.gwt.user.client.ui.FlowPanel;
import com.google.gwt.user.client.ui.Label;
import com.google.gwtexpui.safehtml.client.SafeHtml;
import com.google.gwtexpui.user.client.AutoCenterDialogBox;
import com.google.gwtexpui.user.client.PluginSafePopupPanel;
import com.google.gwtjsonrpc.client.RemoteJsonException;
/** A dialog box showing an error message, when bad things happen. */
public class ErrorDialog extends AutoCenterDialogBox {
public class ErrorDialog extends PluginSafePopupPanel {
private final Label text;
private final FlowPanel body;
protected ErrorDialog() {
super(/* auto hide */true, /* modal */true);
setText(Gerrit.C.errorDialogTitle());
super(/* auto hide */false, /* modal */true);
setGlassEnabled(true);
getGlassElement().addClassName(Gerrit.RESOURCES.css().errorDialogGlass());
text = new Label();
text.setStyleName(Gerrit.RESOURCES.css().errorDialogTitle());
body = new FlowPanel();
final FlowPanel buttons = new FlowPanel();
buttons.setStyleName(Gerrit.RESOURCES.css().errorDialogButtons());
final Button closey = new Button();
closey.setText(Gerrit.C.errorDialogClose());
closey.setText(Gerrit.C.errorDialogContinue());
closey.addClickHandler(new ClickHandler() {
@Override
public void onClick(ClickEvent event) {
@@ -47,10 +55,17 @@ public class ErrorDialog extends AutoCenterDialogBox {
buttons.add(closey);
final FlowPanel center = new FlowPanel();
center.setStyleName(Gerrit.RESOURCES.css().errorDialog());
center.add(text);
center.add(body);
center.add(buttons);
setText(Gerrit.C.errorDialogTitle());
addStyleName(Gerrit.RESOURCES.css().errorDialog());
add(center);
int l = Window.getScrollLeft() + 20;
int t = Window.getScrollTop() + 20;
setPopupPosition(l, t);
}
/** Create a dialog box to show a single message string. */
@@ -95,4 +110,13 @@ public class ErrorDialog extends AutoCenterDialogBox {
body.add(r);
body.add(new Label(what.getMessage()));
}
public void setText(final String t) {
text.setText(t);
}
@Override
public void center() {
show();
}
}