opendev/gerrit
Code Issues Proposed changes

Remove 'final' from method signatures across gerrit.

Browse Source 
Change-Id: I986a5507aa26ceb28305a7b08991e85238bde0e3
This commit is contained in:
Han-Wen Nienhuys
2017-06-13 18:10:03 +02:00
committed by Edwin Kempin
parent 64e43c24ef
commit b0fb0a7a96
424 changed files with 1381 additions and 1465 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-cache-h2/src/main/java/com/google/gerrit/server/cache/h2/H2CacheFactory.java vendored
View File

@@ -115,7 +115,7 @@ class H2CacheFactory implements PersistentCacheFactory, LifecycleListener {
@Override
public void start() {
if (executor != null) {
for (final H2CacheImpl<?, ?> cache : caches) {
for (H2CacheImpl<?, ?> cache : caches) {
executor.execute(cache::start);
@SuppressWarnings("unused")
Future<?> possiblyIgnoredError =

8
gerrit-cache-h2/src/main/java/com/google/gerrit/server/cache/h2/H2CacheImpl.java vendored
View File

@@ -150,7 +150,7 @@ public class H2CacheImpl<K, V> extends AbstractLoadingCache<K, V> implements Per
}
@Override
public void put(final K key, V val) {
public void put(K key, V val) {
final ValueHolder<V> h = new ValueHolder<>(val);
h.created = TimeUtil.nowMs();
mem.put(key, h);
@@ -159,7 +159,7 @@ public class H2CacheImpl<K, V> extends AbstractLoadingCache<K, V> implements Per
@SuppressWarnings("unchecked")
@Override
public void invalidate(final Object key) {
public void invalidate(Object key) {
if (keyType.getRawType().isInstance(key) && store.mightContain((K) key)) {
executor.execute(() -> store.invalidate((K) key));
}
@@ -201,7 +201,7 @@ public class H2CacheImpl<K, V> extends AbstractLoadingCache<K, V> implements Per
store.close();
}
void prune(final ScheduledExecutorService service) {
void prune(ScheduledExecutorService service) {
store.prune(mem);
Calendar cal = Calendar.getInstance();
@@ -239,7 +239,7 @@ public class H2CacheImpl<K, V> extends AbstractLoadingCache<K, V> implements Per
}
@Override
public ValueHolder<V> load(final K key) throws Exception {
public ValueHolder<V> load(K key) throws Exception {
if (store.mightContain(key)) {
ValueHolder<V> h = store.getIfPresent(key);
if (h != null) {