opendev/gerrit
Code Issues Proposed changes

Remove 'final' from method signatures across gerrit.

Browse Source 
Change-Id: I986a5507aa26ceb28305a7b08991e85238bde0e3
This commit is contained in:
Han-Wen Nienhuys
2017-06-13 18:10:03 +02:00
committed by Edwin Kempin
parent 64e43c24ef
commit b0fb0a7a96
424 changed files with 1381 additions and 1465 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
gerrit-launcher/src/main/java/com/google/gerrit/launcher/GerritLauncher.java
View File

@@ -59,11 +59,11 @@ public final class GerritLauncher {
private static ClassLoader daemonClassLoader;
public static void main(final String[] argv) throws Exception {
public static void main(String[] argv) throws Exception {
System.exit(mainImpl(argv));
}
public static int mainImpl(final String[] argv) throws Exception {
public static int mainImpl(String[] argv) throws Exception {
if (argv.length == 0) {
File me;
try {
@@ -108,7 +108,7 @@ public final class GerritLauncher {
return invokeProgram(cl, argv);
}
public static void daemonStart(final String[] argv) throws Exception {
public static void daemonStart(String[] argv) throws Exception {
if (daemonClassLoader != null) {
throw new IllegalStateException("daemonStart can be called only once per JVM instance");
}
@@ -128,7 +128,7 @@ public final class GerritLauncher {
}
}
public static void daemonStop(final String[] argv) throws Exception {
public static void daemonStop(String[] argv) throws Exception {
if (daemonClassLoader == null) {
throw new IllegalStateException("daemonStop can be called only after call to daemonStop");
}
@@ -148,7 +148,7 @@ public final class GerritLauncher {
return "PrologShell".equals(cn) || "Rulec".equals(cn);
}
private static String getVersion(final File me) {
private static String getVersion(File me) {
if (me == null) {
return "";
}
@@ -163,8 +163,7 @@ public final class GerritLauncher {
}
}
private static int invokeProgram(final ClassLoader loader, final String[] origArgv)
throws Exception {
private static int invokeProgram(ClassLoader loader, String[] origArgv) throws Exception {
String name = origArgv[0];
final String[] argv = new String[origArgv.length - 1];
System.arraycopy(origArgv, 1, argv, 0, argv.length);
@@ -316,7 +315,7 @@ public final class GerritLauncher {
}
}
private static String safeName(final ZipEntry ze) {
private static String safeName(ZipEntry ze) {
// Try to derive the name of the temporary file so it
// doesn't completely suck. Best if we can make it
// match the name it was in the archive.
@@ -535,7 +534,7 @@ public final class GerritLauncher {
if (tmpEntries != null) {
final long now = System.currentTimeMillis();
final long expired = now - MILLISECONDS.convert(7, DAYS);
for (final File tmpEntry : tmpEntries) {
for (File tmpEntry : tmpEntries) {
if (tmpEntry.isDirectory() && tmpEntry.lastModified() < expired) {
final String[] all = tmpEntry.list();
if (all == null || all.length == 0) {