opendev/gerrit
Code Issues Proposed changes

Remove 'final' from method signatures across gerrit.

Browse Source 
Change-Id: I986a5507aa26ceb28305a7b08991e85238bde0e3
This commit is contained in:
Han-Wen Nienhuys
2017-06-13 18:10:03 +02:00
committed by Edwin Kempin
parent 64e43c24ef
commit b0fb0a7a96
424 changed files with 1381 additions and 1465 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gerrit-server/src/main/java/com/google/gerrit/rules/PredicateClassLoader.java
View File

@@ -26,7 +26,7 @@ public class PredicateClassLoader extends ClassLoader {
LinkedHashMultimap.create();
public PredicateClassLoader(
final DynamicSet<PredicateProvider> predicateProviders, final ClassLoader parent) {
final DynamicSet<PredicateProvider> predicateProviders, ClassLoader parent) {
super(parent);
for (PredicateProvider predicateProvider : predicateProviders) {
@@ -37,10 +37,10 @@ public class PredicateClassLoader extends ClassLoader {
}
@Override
protected Class<?> findClass(final String className) throws ClassNotFoundException {
protected Class<?> findClass(String className) throws ClassNotFoundException {
final Collection<ClassLoader> classLoaders =
packageClassLoaderMap.get(getPackageName(className));
for (final ClassLoader cl : classLoaders) {
for (ClassLoader cl : classLoaders) {
try {
return Class.forName(className, true, cl);
} catch (ClassNotFoundException e) {

2
gerrit-server/src/main/java/com/google/gerrit/rules/PrologEnvironment.java
View File

@@ -137,7 +137,7 @@ public class PrologEnvironment extends BufferingPrologControl {
/** Release resources stored in interpreter's hash manager. */
public void close() {
for (final Iterator<Runnable> i = cleanup.iterator(); i.hasNext(); ) {
for (Iterator<Runnable> i = cleanup.iterator(); i.hasNext(); ) {
try {
i.next().run();
} catch (Throwable err) {