opendev/gerrit
Code Issues Proposed changes

Catch NumberFormatException on invalid request

Browse Source 
This prevents NumberFormatException in RestApiServlet on queries like:

GET /gerrit/changes/?n=25&O=815%20oR%209%3D9%20%2B%201

Which results with

ERROR| RestApiServlet | Error in GET
/gerrit/changes/?n=25&O=815%20oR%209%3D9%20%2B%201
java.lang.NumberFormatException: For input string: "815 oR 9=9 + 1"

plus the stack trace without this patch.

Change-Id: I631c51e768095998f87d861fd09d0394f23c81c1
Signed-off-by: Eryk Szymanski <eryksz@gmail.com>
This commit is contained in:
Eryk Szymanski
2016-07-18 12:25:15 +02:00
parent bcec870758
commit b158469d2d
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-httpd/src/main/java/com/google/gerrit/httpd/restapi/ParameterParser.java
View File

@@ -66,7 +66,7 @@ class ParameterParser {
CmdLineParser clp = parserFactory.create(param);
try {
clp.parseOptionMap(in);
} catch (CmdLineException e) {
} catch (CmdLineException | NumberFormatException e) {
if (!clp.wasHelpRequestedByOption()) {
replyError(req, res, SC_BAD_REQUEST, e.getMessage(), e);
return false;