opendev/gerrit
Code Issues Proposed changes

PatchListCacheImpl: explicitly check for null revision

Browse Source 
Change-Id: Ib88d104ebd288e16ee2499ca93cecd4a8b9e2b2a
(cherry picked from commit 8909bc4c2c)
This commit is contained in:
Dave Borowitz
2013-10-29 11:19:35 -07:00
committed by David Pursehouse
parent c9b686056e
commit b1d685db43
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchListCacheImpl.java
View File

@@ -90,6 +90,10 @@ public class PatchListCacheImpl implements PatchListCache {
throws PatchListNotAvailableException { throws PatchListNotAvailableException {
final Project.NameKey projectKey = change.getProject(); final Project.NameKey projectKey = change.getProject();
final ObjectId a = null; final ObjectId a = null;
if (patchSet.getRevision() == null) {
throw new PatchListNotAvailableException(
"revision is null for " + patchSet.getId());
}
final ObjectId b = ObjectId.fromString(patchSet.getRevision().get()); final ObjectId b = ObjectId.fromString(patchSet.getRevision().get());
final Whitespace ws = Whitespace.IGNORE_NONE; final Whitespace ws = Whitespace.IGNORE_NONE;
return get(new PatchListKey(projectKey, a, b, ws)); return get(new PatchListKey(projectKey, a, b, ws));