opendev/gerrit
Code Issues Proposed changes

Remove @SecondaryKey from AccountGroup

Browse Source 
Like our prior changes, we need to drop these @SecondaryKey
annotations for databases which don't support multiple keys
on a single entity.

For the external name attribute we simply change it to honor
a list of groups which match the external name.  This allows
an administrator to create multiple groups in Gerrit that use
the same underlying LDAP group for membership.  Its crazy to
do, but there isn't really any good reason to not allow it.

For the internal name attribute we create a new entity that
can be used to enforce uniqueness on the name attribute, and
connects the name to the group.

Change-Id: I933c38a6a4e2c3ed3d7d5a66cab04c2e7175e24f
Signed-off-by: Shawn O. Pearce <sop@google.com>
This commit is contained in:
Shawn O. Pearce
2009-12-31 10:26:26 -08:00
parent b80f07dd5e
commit b1dac0a73b
18 changed files with 379 additions and 87 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
gerrit-reviewdb/src/main/resources/com/google/gerrit/reviewdb/index_generic.sql
View File

@@ -33,7 +33,6 @@ ON account_external_ids (email_address);
-- *********************************************************************
-- AccountGroupAccess
-- @SecondaryKey("name") covers: all, suggestByName
CREATE INDEX account_groups_ownedByGroup
ON account_groups (owner_group_id);

1
gerrit-reviewdb/src/main/resources/com/google/gerrit/reviewdb/index_postgres.sql
View File

@@ -72,7 +72,6 @@ ON account_external_ids (email_address);
-- *********************************************************************
-- AccountGroupAccess
-- @SecondaryKey("name") covers: all, suggestByName
CREATE INDEX account_groups_ownedByGroup
ON account_groups (owner_group_id);