Avoid passing ChangeControl to ChangeMessageModifier.onSubmit.

Follow up on https://gerrit-review.googlesource.com/c/91991.

Bug: Issue 5003
Change-Id: I7571ebe05d2924d6fbb8d94ec8bb1440abfda238

gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/api/change/ChangeIT.java

@@ -1820,12 +1820,10 @@ public class ChangeIT extends AbstractDaemonTest {
     PushOneCommit.Result change = createChange();
     RegistrationHandle handle =
         changeMessageModifiers.add(new ChangeMessageModifier() {
-
           @Override
           public String onSubmit(String newCommitMessage, RevCommit original,
-              RevCommit mergeTip, ChangeControl ctl) {
+              RevCommit mergeTip, Branch.NameKey destination) {
-            return newCommitMessage + "Custom: "
+            return newCommitMessage + "Custom: " + destination.get();
-                + ctl.getChange().getDest().get();
           }
         });
     ChangeInfo actual;

gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/rest/change/SubmitByCherryPickIT.java

@@ -29,12 +29,12 @@ import com.google.gerrit.extensions.common.ChangeInfo;
 import com.google.gerrit.extensions.registration.DynamicSet;
 import com.google.gerrit.extensions.registration.RegistrationHandle;
 import com.google.gerrit.extensions.restapi.ResourceConflictException;
+import com.google.gerrit.reviewdb.client.Branch;
 import com.google.gerrit.reviewdb.client.Change;
 import com.google.gerrit.reviewdb.client.PatchSet;
 import com.google.gerrit.server.change.Submit.TestSubmitInput;
 import com.google.gerrit.server.git.ChangeMessageModifier;
 import com.google.gerrit.server.git.strategy.CommitMergeStatus;
-import com.google.gerrit.server.project.ChangeControl;
 import com.google.inject.Inject;
 
 import org.eclipse.jgit.lib.ObjectId;
@@ -103,9 +103,8 @@ public class SubmitByCherryPickIT extends AbstractSubmit {
         changeMessageModifiers.add(new ChangeMessageModifier() {
           @Override
           public String onSubmit(String newCommitMessage, RevCommit original,
-              RevCommit mergeTip, ChangeControl ctl) {
+              RevCommit mergeTip, Branch.NameKey destination) {
-            return newCommitMessage + "Custom: "
+            return newCommitMessage + "Custom: " + destination.get();
-                + ctl.getChange().getDest().get();
           }
         });
     try {

gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/rest/change/SubmitByRebaseAlwaysIT.java

@@ -24,8 +24,8 @@ import com.google.gerrit.extensions.client.SubmitType;
 import com.google.gerrit.extensions.common.ChangeInfo;
 import com.google.gerrit.extensions.registration.DynamicSet;
 import com.google.gerrit.extensions.registration.RegistrationHandle;
+import com.google.gerrit.reviewdb.client.Branch;
 import com.google.gerrit.server.git.ChangeMessageModifier;
-import com.google.gerrit.server.project.ChangeControl;
 import com.google.inject.Inject;
 
 import org.eclipse.jgit.lib.ObjectId;
@@ -95,13 +95,12 @@ public class SubmitByRebaseAlwaysIT extends AbstractSubmitByRebase {
         changeMessageModifiers.add(new ChangeMessageModifier() {
           @Override
           public String onSubmit(String newCommitMessage, RevCommit original,
-              RevCommit mergeTip, ChangeControl ctl) {
+              RevCommit mergeTip, Branch.NameKey destination) {
             List<String> custom = mergeTip.getFooterLines("Custom");
             if (!custom.isEmpty()) {
               newCommitMessage += "Custom-Parent: " + custom.get(0) + "\n";
             }
-            return newCommitMessage + "Custom: "
+            return newCommitMessage + "Custom: " + destination.get();
-                + ctl.getChange().getDest().get();
           }
         });
     try {

gerrit-server/src/main/java/com/google/gerrit/server/git/ChangeMessageModifier.java

@@ -15,7 +15,7 @@
 package com.google.gerrit.server.git;
 
 import com.google.gerrit.extensions.annotations.ExtensionPoint;
-import com.google.gerrit.server.project.ChangeControl;
+import com.google.gerrit.reviewdb.client.Branch;
 
 import org.eclipse.jgit.revwalk.RevCommit;
 
@@ -45,9 +45,9 @@ public interface ChangeMessageModifier {
    *        commit message may be different than newCommitMessage argument.</b>
    * @param mergeTip the current HEAD of the destination branch, which will be a
    *        parent of a new commit being generated
-   * @param ctl
+   * @param destination the branch onto which the change is being submitted
    * @return a new not null commit message.
    */
   String onSubmit(String newCommitMessage, RevCommit original,
-      RevCommit mergeTip, ChangeControl ctl);
+      RevCommit mergeTip, Branch.NameKey destination);
 }

gerrit-server/src/main/java/com/google/gerrit/server/git/MergeUtil.java

@@ -120,7 +120,7 @@ public class MergeUtil {
       }
       for (ChangeMessageModifier changeMessageModifier : changeMessageModifiers) {
         current = changeMessageModifier.onSubmit(current, original,
-            mergeTip, ctl);
+            mergeTip, ctl.getChange().getDest());
         checkNotNull(current, changeMessageModifier.getClass().getName()
             + ".OnSubmit returned null instead of new commit message");
       }