opendev/gerrit
Code Issues Proposed changes

Use AtomicBoolean for "logged" in CommandFactoryProvider.

Browse Source 
This simplifies the synchronization logic for the log method in
CommandFactoryProvider.

Change-Id: Ifdae88ec3b72a18eb9529f7f27f012bbb88ea2b9
This commit is contained in:
Colby Ranger
2012-05-08 10:28:03 -07:00
committed by Sasa Zivkov
parent 63a0fcc492
commit b2187baf0e
1 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
gerrit-sshd/src/main/java/com/google/gerrit/sshd/CommandFactoryProvider.java
View File

@@ -36,6 +36,7 @@ import java.io.OutputStream;
import java.util.ArrayList;
import java.util.List;
import java.util.concurrent.Executor;
import java.util.concurrent.atomic.AtomicBoolean;
/**
* Creates a CommandFactory using commands registered by {@link CommandModule}.
@@ -79,11 +80,12 @@ class CommandFactoryProvider implements Provider<CommandFactory> {
private Environment env;
private Context ctx;
private DispatchCommand cmd;
private boolean logged;
private final AtomicBoolean logged;
Trampoline(final String cmdLine) {
commandLine = cmdLine;
argv = split(cmdLine);
logged = new AtomicBoolean();
}
public void setInputStream(final InputStream in) {
@@ -173,11 +175,8 @@ class CommandFactoryProvider implements Provider<CommandFactory> {
}
private void log(final int rc) {
synchronized (this) {
if (!logged) {
log.onExecute(rc);
logged = true;
}
if (logged.compareAndSet(false, true)) {
log.onExecute(rc);
}
}