opendev/gerrit
Code Issues Proposed changes

Error Prone: Enable and fix OperatorPrecedence

Browse Source 
Change-Id: I1c9e79a37cba650b1526793fc7997544bb99aafc
This commit is contained in:
Dave Borowitz
2019-05-24 10:57:09 -07:00
committed by David Pursehouse
parent 2bc50b4995
commit b21dde3068
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
java/com/google/gerrit/server/submit/SubmoduleOp.java
View File

@@ -646,7 +646,7 @@ public class SubmoduleOp {
int newSize = msgbuf.length() + bullet.length() + message.length();
if (++numMessages > maxCommitMessages
|| newSize > maxCombinedCommitMessageSize
|| iter.hasNext() && (newSize + ellipsis.length()) > maxCombinedCommitMessageSize) {
|| (iter.hasNext() && (newSize + ellipsis.length()) > maxCombinedCommitMessageSize)) {
msgbuf.append(ellipsis);
break;
}

2
tools/BUILD
View File

@@ -80,7 +80,7 @@ java_package_configuration(
"-Xep:NullableConstructor:ERROR",
"-Xep:NullablePrimitive:ERROR",
"-Xep:NullableVoid:ERROR",
#"-Xep:OperatorPrecedence:ERROR",
"-Xep:OperatorPrecedence:ERROR",
"-Xep:OverridesGuiceInjectableMethod:ERROR",
"-Xep:PreconditionsInvalidPlaceholder:ERROR",
"-Xep:ProtoFieldPreconditionsCheckNotNull:ERROR",