opendev/gerrit
Code Issues Proposed changes

Correct fix for potential NPE in PrettyFormatter

Browse Source 
Commit 6eabad25087fa6f1595353078ed933cc43ad7ec8 fixed a possible NPE
in PrettyFormatter but afterwards FindBugs started to report a
potential NPE on a follow-up line.

Change-Id: I18d112e70c6a84f436003932054e6adaa517dae1
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
This commit is contained in:
Edwin Kempin 2014-03-04 11:14:56 +01:00
parent 5cc0690f7d
commit b23a13d4a7
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-prettify/src/main/java/com/google/gerrit/prettify/client/PrettyFormatter.java
View File

@ -408,7 +408,7 @@ public abstract class PrettyFormatter implements SparseHtmlFile {
String line = src.get(index) + "\n";
for (int c = 0; c < line.length();) {
if (charEdits != null && charEdits.size() <= lastIdx) {
if (charEdits == null || (charEdits.size() <= lastIdx)) {
appendShowBareCR(buf, line.substring(c), false);
break;
}