opendev/gerrit
Code Issues Proposed changes

SystemConfig: increase site path length from 255 char to CLOB

Browse Source 
Sandboxed unit tests are failing on CI: [1] because of too long site
path. Alter the size of the column from char 255 to CLOB.

[1] https://gerrit-ci.gerritforge.com/view/Gerrit/job/Gerrit-master-bazel/237/console

Change-Id: Ife55c0687d3c1f3ee7ba52626622ac8f35768a8d
This commit is contained in:
David Ostrovsky 2016-11-03 21:37:07 +01:00
parent 3f771978e0
commit b25f267f5d
3 changed files with 28 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-reviewdb/src/main/java/com/google/gerrit/reviewdb/client/SystemConfig.java
View File

@ -55,7 +55,7 @@ public final class SystemConfig {
/**
* Local filesystem location of header/footer/CSS configuration files
*/
@Column(id = 3, notNull = false)
@Column(id = 3, notNull = false, length = Integer.MAX_VALUE)
public transient String sitePath;

2
gerrit-server/src/main/java/com/google/gerrit/server/schema/SchemaVersion.java
View File

@ -36,7 +36,7 @@ import java.util.concurrent.TimeUnit;
/** A version of the database schema. */
public abstract class SchemaVersion {
/** The current schema version. */
public static final Class<Schema_136> C = Schema_136.class;
public static final Class<Schema_137> C = Schema_137.class;
public static int getBinaryVersion() {
return guessVersion(C);

26
gerrit-server/src/main/java/com/google/gerrit/server/schema/Schema_137.java Normal file
View File

@ -0,0 +1,26 @@
// Copyright (C) 2016 The Android Open Source Project
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package com.google.gerrit.server.schema;
import com.google.inject.Inject;
import com.google.inject.Provider;
/* change the type of SystemConfig#sitePath to CLOB */
public class Schema_137 extends SchemaVersion {
@Inject
Schema_137(Provider<Schema_136> prior) {
super(prior);
}
}