opendev/gerrit
Code Issues Proposed changes

Merge changes from topic "new-TraceContext-newTimer-signature"

Browse Source 
* changes:
  ReceiveCommits: Pull up trace context from processCommandsUnsafe into processCommands
  Log warning when LoggingContext of background thread is not initially empty
  Unset logging context before returning a thread back to the thread pool
  Add extension point to record execution times in a performance log
  TraceContext#newTimer: Separate message from arguments
This commit is contained in:
Edwin Kempin
2019-06-13 11:39:35 +00:00
committed by Gerrit Code Review
parent ce7fea34da 2f6a8ffd27
commit b277edfe60
41 changed files with 2099 additions and 449 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
java/com/google/gerrit/server/account/externalids/ExternalIdCacheImpl.java
View File

@@ -157,8 +157,7 @@ class ExternalIdCacheImpl implements ExternalIdCache {
@Override
public AllExternalIds load(ObjectId notesRev) throws Exception {
try (TraceTimer timer =
TraceContext.newTimer("Loading external IDs (revision=%s)", notesRev)) {
try (TraceTimer timer = TraceContext.newTimer("Loading external IDs", "revision", notesRev)) {
ImmutableSet<ExternalId> externalIds = externalIdReader.all(notesRev);
externalIds.forEach(ExternalId::checkThatBlobIdIsSet);
return AllExternalIds.create(externalIds);