opendev/gerrit
Code Issues Proposed changes

Remove the use of + when using StringBuilder (1 of 2)

Browse Source 
Change-Id: I010b487de26c5a16b3dfda41130d7ea91b1587e8
This commit is contained in:
Matt Baker
2013-12-08 19:59:00 -07:00
parent 8e19090765
commit b2a7d239bd
12 changed files with 29 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
gerrit-gwtexpui/src/main/java/com/google/gwtexpui/linker/rebind/ServerPlannedIFrameLinker.java
View File

@@ -48,7 +48,8 @@ public class ServerPlannedIFrameLinker extends AbstractLinker {
}
for (CompilationResult r : artifacts.find(CompilationResult.class)) {
table.append(r.getStrongName() + "\n");
table.append(r.getStrongName());
table.append("\n");
for (SortedMap<SelectionProperty, String> p : r.getPropertyMap()) {
for (Map.Entry<SelectionProperty, String> e : p.entrySet()) {
table.append(" ");

4
gerrit-gwtexpui/src/main/java/com/google/gwtexpui/linker/server/Permutation.java
View File

@@ -100,8 +100,8 @@ public class Permutation {
// Prevents mixed mode security in IE6/7.
s.append("f.src=\"javascript:''\";");
s.append("f.id=n;");
s.append("f.style.cssText"
+ "='position:absolute;width:0;height:0;border:none';");
s.append("f.style.cssText)")
.append("='position:absolute;width:0;height:0;border:none';");
s.append("f.tabIndex=-1;");
s.append("d.body.appendChild(f);");