opendev/gerrit
Code Issues Proposed changes

Merge "Fix Show Inherited Rights behavior on refrights table reload"

Browse Source
This commit is contained in:
Shawn Pearce
2011-04-21 09:50:35 -07:00
committed by Android Code Review
parent 76ad93ee69 a9d1575535
commit b2bc916f47
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectAccessScreen.java
View File

@@ -53,6 +53,7 @@ public class ProjectAccessScreen extends ProjectScreen {
private RightsTable rights; private RightsTable rights;
private Button delRight; private Button delRight;
private AccessRightEditor rightEditor; private AccessRightEditor rightEditor;
private CheckBox showInherited;
public ProjectAccessScreen(final Project.NameKey toShow) { public ProjectAccessScreen(final Project.NameKey toShow) {
super(toShow); super(toShow);
@@ -85,18 +86,18 @@ public class ProjectAccessScreen extends ProjectScreen {
private void initParent() { private void initParent() {
parentName = new Hyperlink("", ""); parentName = new Hyperlink("", "");
final CheckBox show = new CheckBox(); showInherited = new CheckBox();
show.setChecked(true); showInherited.setChecked(true);
show.addClickHandler(new ClickHandler() { showInherited.addClickHandler(new ClickHandler() {
public void onClick(ClickEvent event) { public void onClick(ClickEvent event) {
rights.showInherited(show.isChecked()); rights.showInherited(showInherited.isChecked());
} }
}); });
Grid g = new Grid(2, 3); Grid g = new Grid(2, 3);
g.setWidget(0, 0, new SmallHeading(Util.C.headingParentProjectName())); g.setWidget(0, 0, new SmallHeading(Util.C.headingParentProjectName()));
g.setWidget(1, 0, parentName); g.setWidget(1, 0, parentName);
g.setWidget(1, 1, show); g.setWidget(1, 1, showInherited);
g.setText(1, 2, Util.C.headingShowInherited()); g.setText(1, 2, Util.C.headingShowInherited());
parentPanel = new VerticalPanel(); parentPanel = new VerticalPanel();
@@ -214,6 +215,9 @@ public class ProjectAccessScreen extends ProjectScreen {
for (final InheritedRefRight r : refRights) { for (final InheritedRefRight r : refRights) {
final int row = table.getRowCount(); final int row = table.getRowCount();
table.insertRow(row); table.insertRow(row);
if (! showInherited.isChecked() && r.isInherited()) {
table.getRowFormatter().setVisible(row, false);
}
applyDataRowStyle(row); applyDataRowStyle(row);
populate(row, r); populate(row, r);
} }