opendev/gerrit
Code Issues Proposed changes

HookTestCase: Use auto-closeable streams

Browse Source 
Change-Id: Icc9ad197e95ee982c119b18c197c095cd43f41fc
This commit is contained in:
David Pursehouse
2015-05-29 16:11:46 +09:00
parent 3ffbfb9754
commit b2efbf271f
1 changed files with 2 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
gerrit-server/src/test/java/com/google/gerrit/server/tools/hooks/HookTestCase.java
View File

@@ -122,18 +122,12 @@ public abstract class HookTestCase extends LocalDiskRepositoryTestCase {
hook.setLastModified(time); hook.setLastModified(time);
hooks.put(name, hook); hooks.put(name, hook);
} else if ("jar".equals(protocol)) { } else if ("jar".equals(protocol)) {
InputStream in = url.openStream(); try (InputStream in = url.openStream()) {
try {
hook = File.createTempFile("hook_", ".sh"); hook = File.createTempFile("hook_", ".sh");
cleanup.add(hook); cleanup.add(hook);
FileOutputStream out = new FileOutputStream(hook); try (FileOutputStream out = new FileOutputStream(hook)) {
try {
ByteStreams.copy(in, out); ByteStreams.copy(in, out);
} finally {
out.close();
} }
} finally {
in.close();
} }
hook.setExecutable(true); hook.setExecutable(true);
hooks.put(name, hook); hooks.put(name, hook);