Get rid of some global variables - Part 6

* Replace the following global variables with named imports:
  - GrChangeMetadataApi
  - GrEmailSuggestionsProvider
  - GrGroupSuggestionsProvider
* Update gr-app-global-var-init.js

Change-Id: I3d019377f3af0ecb71f48a58ca43faddeb908083

polygerrit-ui/app/.eslintrc.js

@@ -166,11 +166,8 @@ module.exports = {
     // Instead export variables from modules
     // TODO(dmfilippov): Remove global variables from polygerrit
     "Gerrit": "readonly",
-    "GrChangeMetadataApi": "readonly",
     "GrChangeViewApi": "readonly",
-    "GrEmailSuggestionsProvider": "readonly",
     "GrEventHelper": "readonly",
-    "GrGroupSuggestionsProvider": "readonly",
     "GrPluginActionContext": "readonly",
     "GrPluginRestApi": "readonly",
     "GrRepoApi": "readonly",

polygerrit-ui/app/elements/gr-app-global-var-init.js

@@ -55,6 +55,9 @@ import {EventEmitter} from './shared/gr-event-interface/gr-event-interface.js';
 import {GrAdminApi} from './plugins/gr-admin-api/gr-admin-api.js';
 import {GrAnnotationActionsContext} from './shared/gr-js-api-interface/gr-annotation-actions-context.js';
 import {GrAnnotationActionsInterface} from './shared/gr-js-api-interface/gr-annotation-actions-js-api.js';
+import {GrChangeMetadataApi} from './plugins/gr-change-metadata-api/gr-change-metadata-api.js';
+import {GrEmailSuggestionsProvider} from '../scripts/gr-email-suggestions-provider/gr-email-suggestions-provider.js';
+import {GrGroupSuggestionsProvider} from '../scripts/gr-group-suggestions-provider/gr-group-suggestions-provider.js';
 
 export function initGlobalVariables() {
   window.GrDisplayNameUtils = GrDisplayNameUtils;
@@ -93,4 +96,7 @@ export function initGlobalVariables() {
   window.GrAdminApi = GrAdminApi;
   window.GrAnnotationActionsContext = GrAnnotationActionsContext;
   window.GrAnnotationActionsInterface = GrAnnotationActionsInterface;
+  window.GrChangeMetadataApi = GrChangeMetadataApi;
+  window.GrEmailSuggestionsProvider = GrEmailSuggestionsProvider;
+  window.GrGroupSuggestionsProvider = GrGroupSuggestionsProvider;
 }

polygerrit-ui/app/elements/plugins/gr-change-metadata-api/gr-change-metadata-api.js

@@ -24,27 +24,21 @@ $_documentContainer.innerHTML = `<dom-module id="gr-change-metadata-api">
 
 document.head.appendChild($_documentContainer.content);
 
-(function(window) {
+/** @constructor */
-  'use strict';
+export function GrChangeMetadataApi(plugin) {
-
-  /** @constructor */
-  function GrChangeMetadataApi(plugin) {
   this._hook = null;
   this.plugin = plugin;
-  }
+}
 
-  GrChangeMetadataApi.prototype._createHook = function() {
+GrChangeMetadataApi.prototype._createHook = function() {
   this._hook = this.plugin.hook('change-metadata-item');
-  };
+};
 
-  GrChangeMetadataApi.prototype.onLabelsChanged = function(callback) {
+GrChangeMetadataApi.prototype.onLabelsChanged = function(callback) {
   if (!this._hook) {
     this._createHook();
   }
   this._hook.onAttached(element =>
     this.plugin.attributeHelper(element).bind('labels', callback));
   return this;
-  };
+};
-
-  window.GrChangeMetadataApi = GrChangeMetadataApi;
-})(window);

polygerrit-ui/app/elements/shared/gr-js-api-interface/gr-js-api-interface.js

@@ -16,7 +16,6 @@
  */
 import '../../../scripts/bundled-polymer.js';
 import '../../core/gr-reporting/gr-reporting.js';
-import '../../plugins/gr-change-metadata-api/gr-change-metadata-api.js';
 import '../../plugins/gr-event-helper/gr-event-helper.js';
 import '../../plugins/gr-repo-api/gr-repo-api.js';
 import '../../plugins/gr-settings-api/gr-settings-api.js';

polygerrit-ui/app/elements/shared/gr-js-api-interface/gr-public-js-api.js

@@ -24,6 +24,7 @@ import {GrThemeApi} from '../../plugins/gr-theme-api/gr-theme-api.js';
 import {GrPopupInterface} from '../../plugins/gr-popup-interface/gr-popup-interface.js';
 import {GrAdminApi} from '../../plugins/gr-admin-api/gr-admin-api.js';
 import {GrAnnotationActionsInterface} from './gr-annotation-actions-js-api.js';
+import {GrChangeMetadataApi} from '../../plugins/gr-change-metadata-api/gr-change-metadata-api.js';
 
 (function(window) {
   'use strict';

polygerrit-ui/app/scripts/gr-email-suggestions-provider/gr-email-suggestions-provider.js

@@ -16,14 +16,7 @@
  */
 import {GrDisplayNameUtils} from '../gr-display-name-utils/gr-display-name-utils.js';
 
-(function(window) {
+export class GrEmailSuggestionsProvider {
-  'use strict';
-
-  if (window.GrEmailSuggestionsProvider) {
-    return;
-  }
-
-  class GrEmailSuggestionsProvider {
   constructor(restAPI) {
     this._restAPI = restAPI;
   }
@@ -42,7 +35,5 @@ import {GrDisplayNameUtils} from '../gr-display-name-utils/gr-display-name-utils
       value: {account, count: 1},
     };
   }
-  }
+}
 
-  window.GrEmailSuggestionsProvider = GrEmailSuggestionsProvider;
-})(window);

polygerrit-ui/app/scripts/gr-email-suggestions-provider/gr-email-suggestions-provider_test.html

@@ -33,7 +33,8 @@ limitations under the License.
 <script type="module">
 import '../../test/common-test-setup.js';
 import '../../elements/shared/gr-rest-api-interface/gr-rest-api-interface.js';
-import './gr-email-suggestions-provider.js';
+import {GrEmailSuggestionsProvider} from './gr-email-suggestions-provider.js';
+
 suite('GrEmailSuggestionsProvider tests', () => {
   let sandbox;
   let restAPI;

polygerrit-ui/app/scripts/gr-group-suggestions-provider/gr-group-suggestions-provider.js

@@ -14,14 +14,8 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-(function(window) {
-  'use strict';
 
-  if (window.GrGroupSuggestionsProvider) {
+export class GrGroupSuggestionsProvider {
-    return;
-  }
-
-  class GrGroupSuggestionsProvider {
   constructor(restAPI) {
     this._restAPI = restAPI;
   }
@@ -39,7 +33,4 @@
     return {name: suggestion.name,
       value: {group: {name: suggestion.name, id: suggestion.id}}};
   }
-  }
+}
-
-  window.GrGroupSuggestionsProvider = GrGroupSuggestionsProvider;
-})(window);

polygerrit-ui/app/scripts/gr-group-suggestions-provider/gr-group-suggestions-provider_test.html

@@ -33,7 +33,8 @@ limitations under the License.
 <script type="module">
 import '../../test/common-test-setup.js';
 import '../../elements/shared/gr-rest-api-interface/gr-rest-api-interface.js';
-import './gr-group-suggestions-provider.js';
+import {GrGroupSuggestionsProvider} from './gr-group-suggestions-provider.js';
+
 suite('GrGroupSuggestionsProvider tests', () => {
   let sandbox;
   let restAPI;