From f0882ae522b00a2dc953f0c016a9e9e67e8e4012 Mon Sep 17 00:00:00 2001 From: Yuxuan 'fishy' Wang Date: Tue, 18 Feb 2014 15:21:29 -0800 Subject: [PATCH 1/3] Remove double border around code snippets in documentation Bug: issue 2480 Change-Id: I8aa10bf28f5881ce5d073dfd214e3f6db796177b --- Documentation/doc.css | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/doc.css b/Documentation/doc.css index a1c233393d..b414a28d46 100644 --- a/Documentation/doc.css +++ b/Documentation/doc.css @@ -32,6 +32,12 @@ li p { padding: 2px; } +.listingblock > .content pre { + background: none; + border: 0 solid silver; + padding: 0 0 0 0; +} + dl dt { margin-top: 1em; } From 84ee2b08dafb70e3ebd38a057bb44b98fb718d25 Mon Sep 17 00:00:00 2001 From: Edwin Kempin Date: Wed, 19 Feb 2014 09:22:11 +0100 Subject: [PATCH 2/3] Add border for tables in documentation Without border the tables (e.g. in the REST API documentation) are hard to read. Change-Id: If750c09c8518bac3575ada606e918bf18ccc57bf Signed-off-by: Edwin Kempin --- Documentation/doc.css | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/Documentation/doc.css b/Documentation/doc.css index b414a28d46..6b2cacdbe3 100644 --- a/Documentation/doc.css +++ b/Documentation/doc.css @@ -41,3 +41,13 @@ li p { dl dt { margin-top: 1em; } + +table.tableblock { + border-collapse: collapse; +} + +table.tableblock, +th.tableblock, +td.tableblock { + border: 1px solid #EEE; +} From d8d2deb7ffc9e471514382a456a00bd9149168da Mon Sep 17 00:00:00 2001 From: Edwin Kempin Date: Thu, 20 Feb 2014 14:49:17 +0100 Subject: [PATCH 3/3] Add another case to the prohibited by Gerrit error documentation Change-Id: Ie16b7ae361590023939c04e101c120fe98e79aa1 Signed-off-by: Edwin Kempin --- Documentation/error-prohibited-by-gerrit.txt | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/Documentation/error-prohibited-by-gerrit.txt b/Documentation/error-prohibited-by-gerrit.txt index bad2b3c060..112e29624f 100644 --- a/Documentation/error-prohibited-by-gerrit.txt +++ b/Documentation/error-prohibited-by-gerrit.txt @@ -14,18 +14,21 @@ In particular this error occurs: 2. if you bypass code review without link:access-control.html#category_push_direct['Push'] access right on `refs/heads/*` -3. if you push an annotated tag without +3. if you bypass code review pushing to a non-existing branch without + link:access-control.html#category_create['Create Reference'] access + right on `refs/heads/*` +4. if you push an annotated tag without link:access-control.html#category_push_annotated['Push Annotated Tag'] access right on 'refs/tags/*' -4. if you push a signed tag without +5. if you push a signed tag without link:access-control.html#category_push_signed['Push Signed Tag'] access right on 'refs/tags/*' -5. if you push a lightweight tag without the access right link:access-control.html#category_create['Create +6. if you push a lightweight tag without the access right link:access-control.html#category_create['Create Reference'] for the reference name 'refs/tags/*' -6. if you push a tag with somebody else as tagger and you don't have the +7. if you push a tag with somebody else as tagger and you don't have the link:access-control.html#category_forge_committer['Forge Committer'] access right for the reference name 'refs/tags/*' -7. if you push to a project that is in state 'Read Only' +8. if you push to a project that is in state 'Read Only' For new users it often happens that they accidentally try to bypass code review. The push then fails with the error message 'prohibited