Merge branch 'stable-3.0' into stable-3.1

* stable-3.0:
  Error Prone: Enable and fix ClassCanBeStatic
  AutoRegisterModulesTest: Declare inner classes as static
  Fix issue with auto registering ssh commands
  Convert plugin's name to lowercase when generate hook name

Adjust AutoRegisterModulesTest to use mockito instead of easymock.

Change-Id: Id80ecd921cd4993b797708bf2dc3863a1ec45d9b
This commit is contained in:
David Pursehouse
2020-06-25 08:59:29 +09:00
5 changed files with 110 additions and 3 deletions

View File

@@ -27,7 +27,12 @@
if (opt_moduleName) {
return endpointName + ' ' + opt_moduleName;
} else {
return this._plugin.getPluginName() + '-autogenerated-' + endpointName;
// lowercase in case plugin's name contains uppercase letters
// TODO: this still can not prevent if plugin has invalid char
// other than uppercase, but is the first step
// https://html.spec.whatwg.org/multipage/custom-elements.html#valid-custom-element-name
const pluginName = this._plugin.getPluginName() || 'unknown_plugin';
return pluginName.toLowerCase() + '-autogenerated-' + endpointName;
}
};