opendev/gerrit
Code Issues Proposed changes

Merge "Less related changes jank"

Browse Source
This commit is contained in:
Viktar Donich 2017-02-24 18:31:49 +00:00 committed by Gerrit Code Review
commit b3ae6f0d6a
3 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.js
View File

@ -409,6 +409,7 @@
this._changeNum = value.changeNum;
this._patchRange = patchRange;
this.$.relatedChanges.clear();
this._reload().then(function() {
this._performPostLoadTasks();

5
polygerrit-ui/app/elements/change/gr-change-view/gr-change-view_test.html
View File

@ -479,6 +479,7 @@ limitations under the License.
var reloadPatchDependentStub = sandbox.stub(element,
'_reloadPatchNumDependentResources',
function() { return Promise.resolve(); });
var relatedClearSpy = sandbox.spy(element.$.relatedChanges, 'clear');
var value = {
view: 'gr-change-view',
@ -486,6 +487,8 @@ limitations under the License.
};
element._paramsChanged(value);
assert.isTrue(reloadStub.calledOnce);
assert.isTrue(relatedClearSpy.calledOnce);
element._initialLoadComplete = true;
value.basePatchNum = '1';
@ -493,7 +496,7 @@ limitations under the License.
element._paramsChanged(value);
assert.isFalse(reloadStub.calledTwice);
assert.isTrue(reloadPatchDependentStub.calledOnce);
assert.isTrue(relatedClearSpy.calledOnce);
});
test('reload entire page when patchRange doesnt change', function() {

4
polygerrit-ui/app/elements/change/gr-related-changes-list/gr-related-changes-list.js
View File

@ -53,6 +53,10 @@
'_conflicts, _cherryPicks, _sameTopic)',
],
clear: function() {
this._loading = true;
},
reload: function() {
if (!this.change || !this.patchNum) {
return Promise.resolve();