opendev/gerrit
Code Issues Proposed changes

Rename getPathSetWebLink to getPatchSetWebLink

Browse Source 
Typo introduced in v2.11-rc0~655 (I23716673713db3955d9f1743dee95a87a9db2978,
2014-09-24).

Change-Id: I9cfd2e14ea4ccfbbb7ffa1f50b5ee2ea48aafb0c
This commit is contained in:
Jonathan Nieder
2015-03-12 16:19:15 -07:00
committed by David Pursehouse
parent 1aea830549
commit b3cd6906f8
4 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Documentation/dev-plugins.txt
View File

@@ -1795,7 +1795,7 @@ public class MyWeblinkPlugin implements PatchSetWebLink {
private String imageUrl = "http://placehold.it/16x16.gif"; private String imageUrl = "http://placehold.it/16x16.gif";
@Override @Override
public WebLinkInfo getPathSetWebLink(String projectName, String commit) { public WebLinkInfo getPatchSetWebLink(String projectName, String commit) {
return new WebLinkInfo(name, return new WebLinkInfo(name,
imageUrl, imageUrl,
String.format(placeHolderUrlProjectCommit, project, commit), String.format(placeHolderUrlProjectCommit, project, commit),

2
gerrit-extension-api/src/main/java/com/google/gerrit/extensions/webui/PatchSetWebLink.java
View File

@@ -34,5 +34,5 @@ public interface PatchSetWebLink extends WebLink{
* @return WebLinkInfo that links to patch set in external service, * @return WebLinkInfo that links to patch set in external service,
* null if there should be no link. * null if there should be no link.
*/ */
WebLinkInfo getPathSetWebLink(final String projectName, final String commit); WebLinkInfo getPatchSetWebLink(final String projectName, final String commit);
} }

4
gerrit-server/src/main/java/com/google/gerrit/server/WebLinks.java
View File

@@ -85,7 +85,7 @@ public class WebLinks {
@Override @Override
public WebLinkInfo apply(WebLink webLink) { public WebLinkInfo apply(WebLink webLink) {
return ((PatchSetWebLink)webLink).getPathSetWebLink(project.get(), commit); return ((PatchSetWebLink)webLink).getPatchSetWebLink(project.get(), commit);
} }
}); });
} }
@@ -174,4 +174,4 @@ public class WebLinks {
.transform(transformer) .transform(transformer)
.filter(INVALID_WEBLINK); .filter(INVALID_WEBLINK);
} }
} }

2
plugins/cookbook-plugin

Submodule plugins/cookbook-plugin updated: 133d0a22f4...bb209927b3