opendev/gerrit
Code Issues Proposed changes

Tidy up global capability definitions

Browse Source 
Move MODIFY_ACCOUNT to correct alphabetical order.

Rename DEFAULT_MAX_BATCH_CHANGES to DEFAULT_MAX_BATCH_CHANGES_LIMIT,
and move it up so it's right after BATCH_CHANGES_LIMIT. This makes it
consistent with the way DEFAULT_MAX_QUERY_LIMIT is defined.

Change-Id: Ie71a7a5886f95a50e9dae25ba16b3717e2ce27a7
This commit is contained in:
David Pursehouse
2014-11-21 11:46:57 +09:00
parent 53dc45b612
commit b3f2cf27b9
1 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
gerrit-common/src/main/java/com/google/gerrit/common/data/GlobalCapability.java
View File

@@ -38,12 +38,16 @@ public class GlobalCapability {
/** Maximum number of changes that may be pushed in a batch. */ /** Maximum number of changes that may be pushed in a batch. */
public static final String BATCH_CHANGES_LIMIT = "batchChangesLimit"; public static final String BATCH_CHANGES_LIMIT = "batchChangesLimit";
/**
* Default maximum number of changes that may be pushed in a batch, 0 means no
* limit. This is just used as a suggestion for prepopulating the field in the
* access UI.
*/
private static final int DEFAULT_MAX_BATCH_CHANGES_LIMIT = 0;
/** Can create any account on the server. */ /** Can create any account on the server. */
public static final String CREATE_ACCOUNT = "createAccount"; public static final String CREATE_ACCOUNT = "createAccount";
/** Can modify any account on the server. */
public static final String MODIFY_ACCOUNT = "modifyAccount";
/** Can create any group on the server. */ /** Can create any group on the server. */
public static final String CREATE_GROUP = "createGroup"; public static final String CREATE_GROUP = "createGroup";
@@ -67,6 +71,9 @@ public class GlobalCapability {
/** Can terminate any task using the kill command. */ /** Can terminate any task using the kill command. */
public static final String KILL_TASK = "killTask"; public static final String KILL_TASK = "killTask";
/** Can modify any account on the server. */
public static final String MODIFY_ACCOUNT = "modifyAccount";
/** Queue a user can access to submit their tasks to. */ /** Queue a user can access to submit their tasks to. */
public static final String PRIORITY = "priority"; public static final String PRIORITY = "priority";
@@ -100,13 +107,6 @@ public class GlobalCapability {
/** Can view all pending tasks in the queue (not just the filtered set). */ /** Can view all pending tasks in the queue (not just the filtered set). */
public static final String VIEW_QUEUE = "viewQueue"; public static final String VIEW_QUEUE = "viewQueue";
/**
* Default maximum number of changes that may be pushed in a batch, 0 means no
* limit. This is just used as a suggestion for prepopulating the field in the
* access UI.
*/
private static final int DEFAULT_MAX_BATCH_CHANGES = 0;
private static final List<String> NAMES_ALL; private static final List<String> NAMES_ALL;
private static final List<String> NAMES_LC; private static final List<String> NAMES_LC;
@@ -167,7 +167,7 @@ public class GlobalCapability {
return new PermissionRange.WithDefaults( return new PermissionRange.WithDefaults(
varName, varName,
0, Integer.MAX_VALUE, 0, Integer.MAX_VALUE,
0, DEFAULT_MAX_BATCH_CHANGES); 0, DEFAULT_MAX_BATCH_CHANGES_LIMIT);
} }
return null; return null;
} }