opendev/gerrit
Code Issues Proposed changes

ApprovalsUtil: Pass correct committerId to canSee

Browse Source 
Accidentally passed authorId after checking that committerId is not
null, which can lead to NPE if authorId is null.

Change-Id: I178257cd1bc278e7d56c073c4cc6bcbc35ac294c
This commit is contained in:
Dave Borowitz 2016-08-24 19:50:03 -04:00 committed by David Pursehouse
parent 64beae58a2
commit b406068303
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-server/src/main/java/com/google/gerrit/server/ApprovalsUtil.java
View File

@ -221,7 +221,7 @@ public class ApprovalsUtil {
need.add(authorId);
}
if (committerId != null && canSee(db, update.getNotes(), authorId)) {
if (committerId != null && canSee(db, update.getNotes(), committerId)) {
need.add(committerId);
}
need.remove(change.getOwner());