opendev/gerrit
Code Issues Proposed changes

QueryChanges: Include exception cause in BadRequestException

Browse Source 
Change-Id: Ibde8720fe22df5213e4b22481f80085e908e6a46
This commit is contained in:
Dave Borowitz
2016-10-17 14:46:14 -04:00
parent 0457e24291
commit b41078d3a5
2 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
gerrit-extension-api/src/main/java/com/google/gerrit/extensions/restapi/BadRequestException.java
View File

@@ -22,4 +22,12 @@ public class BadRequestException extends RestApiException {
public BadRequestException(String msg) {
super(msg);
}
/**
* @param msg error text for client describing how request is bad.
* @param cause cause of this exception.
*/
public BadRequestException(String msg, Throwable cause) {
super(msg, cause);
}
}

2
gerrit-server/src/main/java/com/google/gerrit/server/query/change/QueryChanges.java
View File

@@ -103,7 +103,7 @@ public class QueryChanges implements RestReadView<TopLevelResource> {
String op = m.group(1);
throw new AuthException("Must be signed-in to use " + op);
}
throw new BadRequestException(e.getMessage());
throw new BadRequestException(e.getMessage(), e);
}
return out.size() == 1 ? out.get(0) : out;
}