opendev/gerrit
Code Issues Proposed changes

Switch off error prone ExpectedExceptionChecker bug pattern

Browse Source 
In I4a774846ad the code was migrated to using assertThrows instead of
ExpectedException. However this change was included only starting from
stable-3.1 branch. Yet we would like to upgrade Bazel version to
earliest supported version which is stable-3.0 branch. Given that Error
Prone version had a major upgrade the existing ExpectedExceptionChecker
check is correctly flagging the usage of ExpectedException and failing
the build.

To rectify, switch off the check for now, but omit it during the merge
of the change to stable-3.1 branch and mention it in the commit message.

Change-Id: I37d0a6752867936aa8a29d16a41b2ce46bdb162e
This commit is contained in:
David Ostrovsky
2020-07-06 19:55:01 +02:00
parent 6730fb7283
commit b415569a19
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tools/BUILD
View File

@@ -39,7 +39,7 @@ java_package_configuration(
"-Xep:ElementsCountedInLoop:WARN",
"-Xep:EqualsHashCode:WARN",
"-Xep:EqualsIncompatibleType:WARN",
"-Xep:ExpectedExceptionChecker:ERROR",
"-Xep:ExpectedExceptionChecker:OFF",
"-Xep:Finally:WARN",
"-Xep:FloatingPointLiteralPrecision:WARN",
"-Xep:FragmentInjection:WARN",