opendev/gerrit
Code Issues Proposed changes

Move CS1 to REST API for reviewer suggestions

Browse Source 
This allows us to remove a lot of code from the deprecated
SuggestServiceImpl, much of which has been duplicated inside of
SuggestReviewers for CS2 and the REST API.

Change-Id: I589b327be626bc4b9ec8c7e7770e8ee1cad4f7df
This commit is contained in:
Shawn Pearce
2014-12-26 19:58:44 -05:00
parent 3f4fe61504
commit b47da24578
6 changed files with 5 additions and 305 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
gerrit-common/src/main/java/com/google/gerrit/common/data/SuggestService.java
View File

@@ -14,7 +14,6 @@
package com.google.gerrit.common.data;
import com.google.gerrit.reviewdb.client.Change;
import com.google.gerrit.reviewdb.client.Project;
import com.google.gwtjsonrpc.common.AsyncCallback;
import com.google.gwtjsonrpc.common.RemoteJsonService;
@@ -27,15 +26,4 @@ import java.util.List;
public interface SuggestService extends RemoteJsonService {
void suggestAccountGroupForProject(Project.NameKey project, String query,
int limit, AsyncCallback<List<GroupReference>> callback);
/**
* Suggests reviewers. A reviewer can be a user or a group. Inactive users,
* the system groups {@code SystemGroupBackend#ANONYMOUS_USERS} and
* {@code SystemGroupBackend#REGISTERED_USERS} and groups that have more than
* the configured {@code addReviewer.maxAllowed} members are not suggested as
* reviewers.
* @param changeId the change for which reviewers should be suggested
*/
void suggestChangeReviewer(Change.Id changeId, String query, int limit,
AsyncCallback<List<ReviewerInfo>> callback);
}