Merge changes I68e3bd39,I30556192,Ie90281fa,Ic23811c1,I8ffe3686, ...

* changes:
  AbstractQueryChangesTest: Make account update atomic
  GerritPublicKeyCheckerTest: Use AccountsUpdate instead of ExternalIdsUpdate
  AccountIT: Use AccountsUpdate instead of ExternalIdsUpdate
  ExternalIdIT: Use AccountsUpdate instead of ExternalIdsUpdate
  AccountManager#link: Update account and external IDs atomically
  AccountManager#create: Create account and external ID atomically
  AccountManager#update: Update account and external IDs atomically
  CreateAccount: Create account and external IDs atomically
  Add specific exception for insert of duplicate external ID key
  CreateAccount: Rollback creation of all ext IDs if insert of email fails
  ChangeUserName: Use AccountsUpdate instead of ExternalIdsUpdate
  ChangeUserName: Remove unused handling of old usernames
  AccountIT#stalenessChecker(): Use ExternalIdNotes instead of ExternalIdsUpdate
  AccountIT: Remove code to reset external IDs after each test
  Add API to update external IDs as part of an account update
  Allow to update external IDs with BatchRefUpdate
  Make Git history of user branches more useful by specific commit messages
  Use BatchRefUpdate to update accounts
  Retry account updates on LockFailureException
  Add an InternalAccountUpdate class to prepare updates to accounts
This commit is contained in:
Edwin Kempin
2017-12-22 15:38:09 +00:00
committed by Gerrit Code Review
35 changed files with 2386 additions and 1306 deletions

View File

@@ -119,12 +119,7 @@ public class AccountCreator {
accountsUpdate
.create()
.insert(
id,
a -> {
a.setFullName(fullName);
a.setPreferredEmail(email);
});
.insert("Create Test Account", id, u -> u.setFullName(fullName).setPreferredEmail(email));
if (groupNames != null) {
for (String n : groupNames) {