From b4ea0fe5aa036937d7def0d2648612764f449e43 Mon Sep 17 00:00:00 2001 From: David Pursehouse Date: Fri, 13 Mar 2015 14:32:41 +0900 Subject: [PATCH] Use Integer.parseInt instead of Integer.valueOf As reported by FindBugs: "A boxed primitive is created from a String, just to extract the unboxed primitive value. It is more efficient to just call the static parseXXX method." Change-Id: Ide32b9fd1432c9f0956dcb13971cf31c0b11e3aa --- .../src/main/java/com/google/gerrit/lucene/QueryBuilder.java | 4 ++-- .../java/com/google/gerrit/server/edit/ChangeEditUtil.java | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/gerrit-lucene/src/main/java/com/google/gerrit/lucene/QueryBuilder.java b/gerrit-lucene/src/main/java/com/google/gerrit/lucene/QueryBuilder.java index 28af0570a1..bb29db211f 100644 --- a/gerrit-lucene/src/main/java/com/google/gerrit/lucene/QueryBuilder.java +++ b/gerrit-lucene/src/main/java/com/google/gerrit/lucene/QueryBuilder.java @@ -164,8 +164,8 @@ public class QueryBuilder { try { // Can't use IntPredicate because it and IndexPredicate are different // subclasses of OperatorPredicate. - value = Integer.valueOf(p.getValue()); - } catch (IllegalArgumentException e) { + value = Integer.parseInt(p.getValue()); + } catch (NumberFormatException e) { throw new QueryParseException("not an integer: " + p.getValue()); } return new TermQuery(intTerm(p.getField().getName(), value)); diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/edit/ChangeEditUtil.java b/gerrit-server/src/main/java/com/google/gerrit/server/edit/ChangeEditUtil.java index 3d2aa6f4e0..f24340f773 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/edit/ChangeEditUtil.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/edit/ChangeEditUtil.java @@ -184,8 +184,8 @@ public class ChangeEditUtil { checkArgument(pos > 0, "invalid edit ref: %s", ref.getName()); String psId = ref.getName().substring(pos + 1); return db.get().patchSets().get(new PatchSet.Id( - change.getId(), Integer.valueOf(psId))); - } catch (OrmException e) { + change.getId(), Integer.parseInt(psId))); + } catch (OrmException | NumberFormatException e) { throw new IOException(e); } }