opendev/gerrit
Code Issues Proposed changes

Common GWT module: Exclude testing package for super dev mode

Browse Source 
The testing package has its own bazel package (it has BUILD file) and
this is not part of the final artifact built with common:client rule.
However, because of wild card inclusion in Common.gwt.xml, the whole
tree is included in GWT module, when used from Eclipse in super dev mode
debug sessions. To avoid needing to add @GwtIncompatible to all files in
this package, exclude this package from GWT module source path in the GWT
module definition.

Change-Id: Ib36348084d59cc5e10f8dc5c7c627fc4e3323609
This commit is contained in:
David Ostrovsky
2018-02-08 23:09:44 +01:00
committed by David Pursehouse
parent d65409b598
commit b51d8cd76d
2 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
java/com/google/gerrit/common/Common.gwt.xml
View File

@@ -18,6 +18,7 @@
<inherits name='com.google.gwtjsonrpc.GWTJSONRPC'/>
<inherits name="com.google.gwt.logging.Logging"/>
<source path="">
<exclude name='**/testing/**/*.java'/>
<include name='**/*.java'/>
</source>
</module>

2
java/com/google/gerrit/common/data/testing/GroupReferenceSubject.java
View File

@@ -16,7 +16,6 @@ package com.google.gerrit.common.data.testing;
import static com.google.common.truth.Truth.assertAbout;
import com.google.common.annotations.GwtIncompatible;
import com.google.common.truth.ComparableSubject;
import com.google.common.truth.FailureMetadata;
import com.google.common.truth.StringSubject;
@@ -25,7 +24,6 @@ import com.google.common.truth.Truth;
import com.google.gerrit.common.data.GroupReference;
import com.google.gerrit.reviewdb.client.AccountGroup;
@GwtIncompatible("Unemulated com.google.gerrit.common.data.testing.GroupReferenceSubject")
public class GroupReferenceSubject extends Subject<GroupReferenceSubject, GroupReference> {
public static GroupReferenceSubject assertThat(GroupReference group) {