opendev/gerrit
Code Issues Proposed changes

Merge "Document need for async title-change"

Browse Source
This commit is contained in:
Viktar Donich
2017-08-02 22:06:09 +00:00
committed by Gerrit Code Review
parent 67df42c3c2 e9bd3e286d
commit b574c495b9
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.js
View File

@@ -472,6 +472,9 @@
}; };
this._path = value.path; this._path = value.path;
// NOTE: This may be called before attachment (e.g. while parentElement is
// null). Fire title-change in an async so that, if attachment to the DOM
// has been queued, the event can bubble up to the handler in gr-app.
this.async(() => { this.async(() => {
this.fire('title-change', this.fire('title-change',
{title: this._computeTruncatedFileDisplayName(this._path)}); {title: this._computeTruncatedFileDisplayName(this._path)});