Merge "Document need for async title-change"

polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.js

@@ -472,6 +472,9 @@
       };
       this._path = value.path;
 
+      // NOTE: This may be called before attachment (e.g. while parentElement is
+      // null). Fire title-change in an async so that, if attachment to the DOM
+      // has been queued, the event can bubble up to the handler in gr-app.
       this.async(() => {
         this.fire('title-change',
             {title: this._computeTruncatedFileDisplayName(this._path)});