opendev/gerrit
Code Issues Proposed changes

Remove 'link' prefix from WebLink field names

Browse Source 
This prefix is unnecessary. Since the entity is called WebLink it's
clear that 'name' is the 'linkName' and 'url' is the 'linkUrl'.

Change-Id: Iae88dd9bb84addfdab3fda18c5bb14d63332b145
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
This commit is contained in:
Edwin Kempin
2014-04-11 15:58:03 +02:00
parent 67128e7017
commit b57d48363c
3 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
gerrit-extension-api/src/main/java/com/google/gerrit/extensions/common/RevisionInfo.java
View File

@@ -29,12 +29,12 @@ public class RevisionInfo {
public List<WebLinkInfo> webLinks;
public static class WebLinkInfo {
public String linkName;
public String linkUrl;
public String name;
public String url;
public WebLinkInfo(String name, String url) {
linkName = name;
linkUrl = url;
this.name = name;
this.url = url;
}
}
}

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/CommitBox.java
View File

@@ -117,7 +117,7 @@ class CommitBox extends Composite {
JsArray<WebLinkInfo> links = revInfo.web_links();
if (links != null) {
for (WebLinkInfo link : Natives.asList(links)) {
addWebLink(link.link_url(), parenthesize(link.link_name()));
addWebLink(link.url(), parenthesize(link.name()));
}
}
}

4
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeInfo.java
View File

@@ -299,8 +299,8 @@ public class ChangeInfo extends JavaScriptObject {
}
public static class WebLinkInfo extends JavaScriptObject {
public final native String link_name() /*-{ return this.link_name; }-*/;
public final native String link_url() /*-{ return this.link_url; }-*/;
public final native String name() /*-{ return this.name; }-*/;
public final native String url() /*-{ return this.url; }-*/;
protected WebLinkInfo() {
}
}