opendev/gerrit
Code Issues Proposed changes

Move BatchUpdate *Op and Listener to new files

Browse Source 
Also make them interfaces, which is a more natural fit. We now have
default method implementations, so an abstract class is not required
here.

Since we have new public interfaces, document them more thoroughly.

Change-Id: Ida16b36cbecffffd9170ecdeaf130b4c9294cebb
This commit is contained in:
Dave Borowitz
2017-03-10 14:02:37 -05:00
parent b91cf223be
commit b5aea604d6
50 changed files with 254 additions and 134 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
gerrit-server/src/main/java/com/google/gerrit/server/change/PutTopic.java
View File

@@ -31,6 +31,7 @@ import com.google.gerrit.server.extensions.events.TopicEdited;
import com.google.gerrit.server.notedb.ChangeUpdate;
import com.google.gerrit.server.project.ChangeControl;
import com.google.gerrit.server.update.BatchUpdate;
import com.google.gerrit.server.update.BatchUpdateOp;
import com.google.gerrit.server.update.ChangeContext;
import com.google.gerrit.server.update.Context;
import com.google.gerrit.server.update.UpdateException;
@@ -82,7 +83,7 @@ public class PutTopic implements RestModifyView<ChangeResource, Input>, UiAction
: Response.ok(op.newTopicName);
}
private class Op extends BatchUpdate.Op {
private class Op implements BatchUpdateOp {
private final Input input;
private Change change;