opendev/gerrit
Code Issues Proposed changes

Improve class naming of group inclusion cache loaders

Browse Source 
In [1] the inner classes were named with lowerCaseNames.
thisIsNotStandard. StandardForClassNamesBeginsWithCaps.

[1] https://gerrit-review.googlesource.com/60356

Change-Id: Ia223cb6f010555841fd00be06c56b880968312fe
This commit is contained in:
Shawn Pearce 2014-12-03 14:21:22 -08:00
parent 7c603dffde
commit b6b88ebe9c
1 changed files with 6 additions and 6 deletions

12
gerrit-server/src/main/java/com/google/gerrit/server/account/GroupIncludeCacheImpl.java

@ -53,12 +53,12 @@ public class GroupIncludeCacheImpl implements GroupIncludeCache {
cache(PARENT_GROUPS_NAME, cache(PARENT_GROUPS_NAME,
AccountGroup.UUID.class, AccountGroup.UUID.class,
new TypeLiteral<Set<AccountGroup.UUID>>() {}) new TypeLiteral<Set<AccountGroup.UUID>>() {})
.loader(parentGroupsLoader.class); .loader(ParentGroupsLoader.class);
cache(SUBGROUPS_NAME, cache(SUBGROUPS_NAME,
AccountGroup.UUID.class, AccountGroup.UUID.class,
new TypeLiteral<Set<AccountGroup.UUID>>() {}) new TypeLiteral<Set<AccountGroup.UUID>>() {})
.loader(subgroupsLoader.class); .loader(SubgroupsLoader.class);
cache(EXTERNAL_NAME, cache(EXTERNAL_NAME,
String.class, String.class,
@ -133,12 +133,12 @@ public class GroupIncludeCacheImpl implements GroupIncludeCache {
} }
} }
static class subgroupsLoader extends static class SubgroupsLoader extends
CacheLoader<AccountGroup.UUID, Set<AccountGroup.UUID>> { CacheLoader<AccountGroup.UUID, Set<AccountGroup.UUID>> {
private final SchemaFactory<ReviewDb> schema; private final SchemaFactory<ReviewDb> schema;
@Inject @Inject
subgroupsLoader(final SchemaFactory<ReviewDb> sf) { SubgroupsLoader(final SchemaFactory<ReviewDb> sf) {
schema = sf; schema = sf;
} }
@ -163,12 +163,12 @@ public class GroupIncludeCacheImpl implements GroupIncludeCache {
} }
} }
static class parentGroupsLoader extends static class ParentGroupsLoader extends
CacheLoader<AccountGroup.UUID, Set<AccountGroup.UUID>> { CacheLoader<AccountGroup.UUID, Set<AccountGroup.UUID>> {
private final SchemaFactory<ReviewDb> schema; private final SchemaFactory<ReviewDb> schema;
@Inject @Inject
parentGroupsLoader(final SchemaFactory<ReviewDb> sf) { ParentGroupsLoader(final SchemaFactory<ReviewDb> sf) {
schema = sf; schema = sf;
} }