opendev/gerrit
Code Issues Proposed changes

ChangeData: inline approvals() and drop Map from approvalsMap()

Browse Source 
Change-Id: I9582be11bda331e03e758d6e8a35057886d976d7
This commit is contained in:
Dave Borowitz
2014-01-21 16:47:48 -08:00
parent 55bc67720e
commit b713b6393f
8 changed files with 11 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-server/src/main/java/com/google/gerrit/server/change/ChangeJson.java
View File

@@ -501,7 +501,7 @@ public class ChangeJson {
// All users ever added, even if they can't vote on one or all labels.
Set<Account.Id> allUsers = Sets.newHashSet();
ListMultimap<PatchSet.Id, PatchSetApproval> allApprovals =
cd.approvalsMap();
cd.approvals();
for (PatchSetApproval psa : allApprovals.values()) {
allUsers.add(psa.getAccountId());
}
@@ -547,7 +547,7 @@ public class ChangeJson {
LabelTypes labelTypes, boolean standard, boolean detailed)
throws OrmException {
Set<Account.Id> allUsers = Sets.newHashSet();
for (PatchSetApproval psa : cd.approvals()) {
for (PatchSetApproval psa : cd.approvals().values()) {
allUsers.add(psa.getAccountId());
}