opendev/gerrit
Code Issues Proposed changes

Only load drafts in CodeMirrorDemo for signed in users

Browse Source 
Drafts are not supported for anonymous users, as there is no way to
identify them and keep the draft private.  Only call the drafts() API
to load drafts if the user is signed in, and only support the "c"
keybindings if the user is signed in.

Change-Id: I8eedc8bd8e18f2c379b362f1f0cad9c85ed508a5
This commit is contained in:
Shawn Pearce
2013-07-06 19:06:04 -07:00
parent 3227f3d80c
commit b7886b9c65
1 changed files with 14 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/CodeMirrorDemo.java
View File

@@ -14,6 +14,7 @@
package com.google.gerrit.client.diff; package com.google.gerrit.client.diff;
import com.google.gerrit.client.Gerrit;
import com.google.gerrit.client.changes.ChangeApi; import com.google.gerrit.client.changes.ChangeApi;
import com.google.gerrit.client.changes.ChangeInfo; import com.google.gerrit.client.changes.ChangeInfo;
import com.google.gerrit.client.changes.CommentApi; import com.google.gerrit.client.changes.CommentApi;
@@ -132,11 +133,15 @@ public class CodeMirrorDemo extends Screen {
@Override @Override
public void onSuccess(NativeMap<JsArray<CommentInfo>> m) { published = m.get(path); } public void onSuccess(NativeMap<JsArray<CommentInfo>> m) { published = m.get(path); }
})); }));
CommentApi.drafts(revision, if (Gerrit.isSignedIn()) {
group.add(new GerritCallback<NativeMap<JsArray<CommentInfo>>>() { CommentApi.drafts(revision,
@Override group.add(new GerritCallback<NativeMap<JsArray<CommentInfo>>>() {
public void onSuccess(NativeMap<JsArray<CommentInfo>> m) { drafts = m.get(path); } @Override
})); public void onSuccess(NativeMap<JsArray<CommentInfo>> m) { drafts = m.get(path); }
}));
} else {
drafts = JsArray.createArray().cast();
}
ChangeApi.detail(revision.getParentKey().get(), new GerritCallback<ChangeInfo>() { ChangeApi.detail(revision.getParentKey().get(), new GerritCallback<ChangeInfo>() {
@Override @Override
public void onSuccess(ChangeInfo result) { public void onSuccess(ChangeInfo result) {
@@ -205,8 +210,10 @@ public class CodeMirrorDemo extends Screen {
drafts = null; drafts = null;
cmA.on("cursorActivity", updateActiveLine(cmA)); cmA.on("cursorActivity", updateActiveLine(cmA));
cmB.on("cursorActivity", updateActiveLine(cmB)); cmB.on("cursorActivity", updateActiveLine(cmB));
cmA.addKeyMap(KeyMap.create().on("'c'", insertNewDraft(cmA))); if (Gerrit.isSignedIn()) {
cmB.addKeyMap(KeyMap.create().on("'c'", insertNewDraft(cmB))); cmA.addKeyMap(KeyMap.create().on("'c'", insertNewDraft(cmA)));
cmB.addKeyMap(KeyMap.create().on("'c'", insertNewDraft(cmB)));
}
// TODO: Probably need horizontal resize // TODO: Probably need horizontal resize
resizeHandler = Window.addResizeHandler(new ResizeHandler() { resizeHandler = Window.addResizeHandler(new ResizeHandler() {
@Override @Override