opendev/gerrit
Code Issues Proposed changes

Add 'a' as shortcut to go to change and open reply box

Browse Source 
This saves one keystroke when going from a file back to the
change screen to send a reply comment.

CodeMirror seems to be eating the 'a' and refuses to let us
bind to the character there.

Change-Id: I2cfac04cad9a9cebe94913ae9f464894df4c2a7d
This commit is contained in:
Shawn Pearce
2013-08-14 13:08:24 -07:00
parent 7f605c1584
commit b7cf9b6271
5 changed files with 44 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
gerrit-gwtui/src/main/java/com/google/gerrit/client/Dispatcher.java
View File

@@ -470,7 +470,9 @@ public class Dispatcher {
if (rest.isEmpty()) {
Gerrit.display(token, panel== null
? (useChangeScreen2 ? new ChangeScreen2(id, null) : new ChangeScreen(id))
? (useChangeScreen2
? new ChangeScreen2(id, null, false)
: new ChangeScreen(id))
: new NotFoundScreen());
return;
}
@@ -502,7 +504,7 @@ public class Dispatcher {
} else {
if (panel == null) {
Gerrit.display(token, useChangeScreen2
? new ChangeScreen2(id, String.valueOf(ps.get()))
? new ChangeScreen2(id, String.valueOf(ps.get()), false)
: new ChangeScreen(id));
} else if ("publish".equals(panel)) {
publish(ps);
@@ -524,7 +526,7 @@ public class Dispatcher {
rest = "";
}
useChangeScreen2 = true;
Gerrit.display(token, new ChangeScreen2(id, rest));
Gerrit.display(token, new ChangeScreen2(id, rest, false));
}
private static void publish(final PatchSet.Id ps) {