opendev/gerrit
Code Issues Proposed changes

Replace $$ with shadowRoot.querySelector

Browse Source 
`$$` is deprecated: https://polymer-library.polymer-project.org/2.0/docs/upgrade

One exception here is for gr-select as its not a shadow dom component,
so use `this.querySelector` instead

Change-Id: Ib3fd45298da1b44325d47932e53e6185d25c13de
This commit is contained in:
Tao Zhou
2020-03-11 10:25:16 +01:00
parent 0220e03503
commit b800561d0e
81 changed files with 1036 additions and 545 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
polygerrit-ui/app/elements/change-list/gr-change-list/gr-change-list.js
View File

@@ -378,7 +378,8 @@
}
const changeEl = changeEls[index];
changeEl.$$('gr-change-star').toggleStar();
changeEl.shadowRoot
.querySelector('gr-change-star').toggleStar();
}
_changeForIndex(index) {

15
polygerrit-ui/app/elements/change-list/gr-change-list/gr-change-list_test.html
View File

@@ -347,7 +347,8 @@ limitations under the License.
test('all columns visible', () => {
for (const column of element.columnNames) {
const elementClass = '.' + element._lowerCase(column);
assert.isFalse(element.$$(elementClass).hidden);
assert.isFalse(element.shadowRoot
.querySelector(elementClass).hidden);
}
});
});
@@ -381,7 +382,8 @@ limitations under the License.
test('all columns visible', () => {
for (const column of element.changeTableColumns) {
const elementClass = '.' + element._lowerCase(column);
assert.isFalse(element.$$(elementClass).hidden);
assert.isFalse(element.shadowRoot
.querySelector(elementClass).hidden);
}
});
});
@@ -415,9 +417,11 @@ limitations under the License.
for (const column of element.changeTableColumns) {
const elementClass = '.' + column.toLowerCase();
if (column === 'Repo') {
assert.isTrue(element.$$(elementClass).hidden);
assert.isTrue(element.shadowRoot
.querySelector(elementClass).hidden);
} else {
assert.isFalse(element.$$(elementClass).hidden);
assert.isFalse(element.shadowRoot
.querySelector(elementClass).hidden);
}
}
});
@@ -443,7 +447,8 @@ limitations under the License.
test('bad column does not exist', () => {
const elementClass = '.bad';
assert.isNotOk(element.$$(elementClass));
assert.isNotOk(element.shadowRoot
.querySelector(elementClass));
});
});