opendev/gerrit
Code Issues Proposed changes

Better naming of Input parameters in ChangeApi

Browse Source 
Change-Id: Ia0c74deb96b918ceabfddc966b8ac6e6eb5f4a4c
This commit is contained in:
Gustaf Lundh
2016-09-22 11:42:12 +02:00
parent e05ea2c90a
commit b87d8b2371
1 changed files with 19 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeApi.java
View File

@@ -34,7 +34,7 @@ import com.google.gwt.user.client.rpc.AsyncCallback;
public class ChangeApi { public class ChangeApi {
/** Abandon the change, ending its review. */ /** Abandon the change, ending its review. */
public static void abandon(int id, String msg, AsyncCallback<ChangeInfo> cb) { public static void abandon(int id, String msg, AsyncCallback<ChangeInfo> cb) {
Input input = Input.create(); MessageInput input = MessageInput.create();
input.message(emptyToNull(msg)); input.message(emptyToNull(msg));
call(id, "abandon").post(input, cb); call(id, "abandon").post(input, cb);
} }
@@ -64,14 +64,14 @@ public class ChangeApi {
/** Restore a previously abandoned change to be open again. */ /** Restore a previously abandoned change to be open again. */
public static void restore(int id, String msg, AsyncCallback<ChangeInfo> cb) { public static void restore(int id, String msg, AsyncCallback<ChangeInfo> cb) {
Input input = Input.create(); MessageInput input = MessageInput.create();
input.message(emptyToNull(msg)); input.message(emptyToNull(msg));
call(id, "restore").post(input, cb); call(id, "restore").post(input, cb);
} }
/** Create a new change that reverts the delta caused by this change. */ /** Create a new change that reverts the delta caused by this change. */
public static void revert(int id, String msg, AsyncCallback<ChangeInfo> cb) { public static void revert(int id, String msg, AsyncCallback<ChangeInfo> cb) {
Input input = Input.create(); MessageInput input = MessageInput.create();
input.message(emptyToNull(msg)); input.message(emptyToNull(msg));
call(id, "revert").post(input, cb); call(id, "revert").post(input, cb);
} }
@@ -81,7 +81,7 @@ public class ChangeApi {
RestApi call = call(id, "topic"); RestApi call = call(id, "topic");
topic = emptyToNull(topic); topic = emptyToNull(topic);
if (topic != null) { if (topic != null) {
Input input = Input.create(); TopicInput input = TopicInput.create();
input.topic(topic); input.topic(topic);
call.put(input, NativeString.unwrap(cb)); call.put(input, NativeString.unwrap(cb));
} else { } else {
@@ -244,15 +244,25 @@ public class ChangeApi {
call(id, commit, "rebase").post(rebaseInput, cb); call(id, commit, "rebase").post(rebaseInput, cb);
} }
private static class Input extends JavaScriptObject { private static class MessageInput extends JavaScriptObject {
final native void topic(String t) /*-{ if(t)this.topic=t; }-*/;
final native void message(String m) /*-{ if(m)this.message=m; }-*/; final native void message(String m) /*-{ if(m)this.message=m; }-*/;
static Input create() { static MessageInput create() {
return (Input) createObject(); return (MessageInput) createObject();
} }
protected Input() { protected MessageInput() {
}
}
private static class TopicInput extends JavaScriptObject {
final native void topic(String t) /*-{ if(t)this.topic=t; }-*/;
static TopicInput create() {
return (TopicInput) createObject();
}
protected TopicInput() {
} }
} }