opendev/gerrit
Code Issues Proposed changes

Remove redundant 'Prev' and 'Next' string constants

Browse Source 
The 'Prev' and 'Next' strings used in paginated lists of groups
and projects are the same, but are defined in separate constants.

Replace them with constants that are used by both.

Change-Id: I88e6bc0a9553c871eac408aca216dd223217fa28
This commit is contained in:
David Pursehouse 2014-08-20 12:02:49 +09:00
parent 709a173fb2
commit b94f9abe9e
4 changed files with 8 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/AdminConstants.java
View File

@ -135,9 +135,6 @@ public interface AdminConstants extends Constants {
String sectionTypeSection();
Map<String, String> sectionNames();
String pagedProjectListPrev();
String pagedProjectListNext();
String pagedGroupListPrev();
String pagedGroupListNext();
String pagedListPrev();
String pagedListNext();
}

7
gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/AdminConstants.properties
View File

@ -99,11 +99,8 @@ noGroupSelected = (No group selected)
errorNoMatchingGroups = No Matching Groups
errorNoGitRepository = No Git Repository
pagedProjectListPrev = &#x21e6;Prev
pagedProjectListNext = Next&#x21e8;
pagedGroupListPrev = &#x21e6;Prev
pagedGroupListNext = Next&#x21e8;
pagedListPrev = &#x21e6;Prev
pagedListNext = Next&#x21e8;
addPermission = Add Permission ...

4
gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/GroupListScreen.java
View File

@ -148,10 +148,10 @@ public class GroupListScreen extends AccountScreen implements FilteredUserInterf
setPageTitle(Util.C.groupListTitle());
initPageHeader();
prev = new Hyperlink(Util.C.pagedGroupListPrev(), true, "");
prev = new Hyperlink(Util.C.pagedListPrev(), true, "");
prev.setVisible(false);
next = new Hyperlink(Util.C.pagedGroupListNext(), true, "");
next = new Hyperlink(Util.C.pagedListNext(), true, "");
next.setVisible(false);
groups = new GroupTable(PageLinks.ADMIN_GROUPS);

4
gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectListScreen.java
View File

@ -161,10 +161,10 @@ public class ProjectListScreen extends Screen implements FilteredUserInterface {
setPageTitle(Util.C.projectListTitle());
initPageHeader();
prev = new Hyperlink(Util.C.pagedProjectListPrev(), true, "");
prev = new Hyperlink(Util.C.pagedListPrev(), true, "");
prev.setVisible(false);
next = new Hyperlink(Util.C.pagedProjectListNext(), true, "");
next = new Hyperlink(Util.C.pagedListNext(), true, "");
next.setVisible(false);
projects = new ProjectsTable() {