opendev/gerrit
Code Issues Proposed changes

ChangeUpdate: Remove now-unused factory method

Browse Source 
Change-Id: I230cd9584b609d777d42cf2151e2fa7f0da23029
This commit is contained in:
Dave Borowitz
2019-04-16 09:14:22 -07:00
parent d2654e074f
commit b9630340d0
1 changed files with 0 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
java/com/google/gerrit/server/notedb/ChangeUpdate.java
View File

@@ -49,7 +49,6 @@ import com.google.common.base.Strings;
import com.google.common.collect.ImmutableList; import com.google.common.collect.ImmutableList;
import com.google.common.collect.Table; import com.google.common.collect.Table;
import com.google.common.collect.TreeBasedTable; import com.google.common.collect.TreeBasedTable;
import com.google.gerrit.common.UsedAt;
import com.google.gerrit.common.data.SubmitRecord; import com.google.gerrit.common.data.SubmitRecord;
import com.google.gerrit.mail.Address; import com.google.gerrit.mail.Address;
import com.google.gerrit.reviewdb.client.Account; import com.google.gerrit.reviewdb.client.Account;
@@ -102,10 +101,6 @@ import org.eclipse.jgit.revwalk.RevWalk;
*/ */
public class ChangeUpdate extends AbstractChangeUpdate { public class ChangeUpdate extends AbstractChangeUpdate {
public interface Factory { public interface Factory {
@Deprecated
@UsedAt(UsedAt.Project.GOOGLE) // TODO(dborowitz): Remove usage, then delete method.
ChangeUpdate create(ChangeNotes notes, CurrentUser user);
ChangeUpdate create(ChangeNotes notes, CurrentUser user, Date when); ChangeUpdate create(ChangeNotes notes, CurrentUser user, Date when);
@VisibleForTesting @VisibleForTesting
@@ -151,30 +146,6 @@ public class ChangeUpdate extends AbstractChangeUpdate {
private DeleteCommentRewriter deleteCommentRewriter; private DeleteCommentRewriter deleteCommentRewriter;
private DeleteChangeMessageRewriter deleteChangeMessageRewriter; private DeleteChangeMessageRewriter deleteChangeMessageRewriter;
@AssistedInject
private ChangeUpdate(
@GerritPersonIdent PersonIdent serverIdent,
NoteDbUpdateManager.Factory updateManagerFactory,
ChangeDraftUpdate.Factory draftUpdateFactory,
RobotCommentUpdate.Factory robotCommentUpdateFactory,
DeleteCommentRewriter.Factory deleteCommentRewriterFactory,
ProjectCache projectCache,
@Assisted ChangeNotes notes,
@Assisted CurrentUser user,
ChangeNoteUtil noteUtil) {
this(
serverIdent,
updateManagerFactory,
draftUpdateFactory,
robotCommentUpdateFactory,
deleteCommentRewriterFactory,
projectCache,
notes,
user,
serverIdent.getWhen(),
noteUtil);
}
@AssistedInject @AssistedInject
private ChangeUpdate( private ChangeUpdate(
@GerritPersonIdent PersonIdent serverIdent, @GerritPersonIdent PersonIdent serverIdent,